15572 - Clean-up build warnings

Status: VERIFIED FIXED

(Core Graveyard :: Tracking, defect, P3)

Description

[Steve Lamm]

Please cleanup your build warnings (url is in the URL field above). Driving for
beta is a great time to bring down the warning noise.

Most of your warnings look look innocuous, but getting them out of the way will
make it easier to spot potentially harmful warnings.

Comment 1

[Stephen P. Morse]

Checked in new versions of wallet.cpp, singsign.cpp, nsSignonViewer.cpp,
nsCookieViewer.cpp, and nsCookie.cpp.  That should get my warning count down to
1.  I don't know how to remove that warning so I'm going to leave it as is
(unless someone can tell me what change to make).

Comment 2

[Steve Lamm]

Where is that value written? Since it is a pointer value, could you write it
with "%p" and scan it with "%p"?

Comment 3

[Stephen P. Morse]

It's written by the following line, also in wallet.cpp.  The item of interest is
wallet_list and it is written with a %ld format.

  g += PR_snprintf(buffer+g, BUFLEN3-g,"%c%ld%c%s", BREAK, wallet_list, BREAK,
urlCString);

Comment 4

[Eli Goldberg]

Slamm, is this fixed to your satisfaction? If so, could you possibly mark it as
'verified'? Thanks!

Comment 5

[Stephen P. Morse]

This is an old bug report.  Since then, I have gotten the build warnings down to
zero.

Comment 6

[Eli Goldberg]

Yup. Clearing out old unverified bugs.

Verified. Thanks.

Comment 7

[Steve Lamm]

Yup, verified. Thanks.