Closed Bug 1557237 Opened 1 year ago Closed 1 year ago

Stop using [array] in nsIPrompt and nsIPromptService

Categories

(Core :: XPCOM, task)

Product:
Core
Component:
XPCOM
Type:
task
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1557237. Stop using [array] in nsIPrompt and nsIPromptService. r=gijs
47 bytes, text/x-phabricator-request
Details | Review
No description provided.

Jorg, I think comm-central will need changes to the select() method in editor/ui/composer/content/ComposerCommands.js. Not sure whether it needs anything else.

Assignee: nobody → bzbarsky

Thanks for the heads-up. I believe that file in related to the SeaMonkey "Composer" (HTML editor). We use these interfaces all over the place, but as far as I understand, only the select() which returns an array will ned to change:
https://searchfox.org/comm-central/rev/4a11fb532256bbd0901758d25ec6a79fb2d87afd/editor/ui/composer/content/ComposerCommands.js#1254

EDIT: Patch arrived now, only Services.prompt.select affected.

Yep, only select() is involved, and pretty much no one uses it. I thought I could remove it, but then ran into a use in Firefox. :(

Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee9309aacb9e
Stop using [array] in nsIPrompt and nsIPromptService.  r=Gijs
Component: Gecko Profiler → XPCOM

https://hg.mozilla.org/mozilla-central/rev/ee9309aacb9e

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox69: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/03aa53d80cf1
C-C part: Adapt to array changes of nsIPrompt.select(). rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.