1557252 - Preference dialog footer is now unstyled

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Tim Nguyen :ntim]

Attachment: Before

See screenshots

Comment 1

[Tim Nguyen :ntim]

Attachment: After

Comment 2

[Tim Nguyen :ntim]

Attachment: After

Whoops, dark mode might be confusing for the screenshots

Comment 3

[:Gijs (he/him)]

:surkov, can you take a look? Looks like your patches broke this. If non-XBL styles no longer apply to the generated wizard/dialog content I'd be pretty concerned there are other broken (less frequently used) consumers, too, so it'd be worth doing an audit for those once we figure out what broke here.

Comment 5

[alexander :surkov (:asurkov)]

Attachment: Bug 1557252 - Preference dialog footer is now unstyled

Comment 6

[alexander :surkov (:asurkov)]

styles from chrome://global/skin/in-content/common.css are not applied

Comment 7

[alexander :surkov (:asurkov)]

Attachment: Bug 1557252 - add missing style for in-content dialog

Comment 8

[alexander :surkov (:asurkov)]

Attachment: Bug 1557252 - add missing style for in-content dialogs, r=bgrins

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/584e6d9246ac
add missing style for in-content dialogs, r=bgrins

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 584e6d9246ac (Bug 1557252) for browser/components/preferences/in-content/tests* failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Ctest-linux64-asan%2Fopt-mochitest-browser-chrome-e10s-2%2Cm%28bc2%29&tochange=7f307bf3d52aaf2af7a0e228311680c75777f97a&selectedJob=250409680

Backout link: https://hg.mozilla.org/integration/autoland/rev/7f307bf3d52aaf2af7a0e228311680c75777f97a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250409680&repo=autoland&lineNumber=1845

Please check the log to see all the failures.

[task 2019-06-06T16:32:20.563Z] 16:32:20 INFO - TEST-START | browser/components/preferences/in-content/tests/browser_containers_name_input.js
[task 2019-06-06T16:32:23.393Z] 16:32:23 INFO - TEST-INFO | started process screentopng
[task 2019-06-06T16:32:23.921Z] 16:32:23 INFO - TEST-INFO | screentopng: exit 0
[task 2019-06-06T16:32:23.921Z] 16:32:23 INFO - Buffered messages logged at 16:32:20
[task 2019-06-06T16:32:23.921Z] 16:32:23 INFO - Entering test bound setup
[task 2019-06-06T16:32:23.921Z] 16:32:23 INFO - Buffered messages logged at 16:32:22
[task 2019-06-06T16:32:23.921Z] 16:32:23 INFO - Leaving test bound setup
[task 2019-06-06T16:32:23.923Z] 16:32:23 INFO - Entering test bound
[task 2019-06-06T16:32:23.924Z] 16:32:23 INFO - Buffered messages finished
[task 2019-06-06T16:32:23.928Z] 16:32:23 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_containers_name_input.js | uncaught exception - TypeError: this._frame.contentDocument.documentElement.setInContent is not a function at _onContentLoaded@chrome://browser/content/preferences/in-content/subdialogs.js:223:49
[task 2019-06-06T16:32:23.929Z] 16:32:23 INFO - handleEvent@chrome://browser/content/preferences/in-content/subdialogs.js:188:14
[task 2019-06-06T16:32:23.930Z] 16:32:23 INFO - EventListener.handleEvent*_addDialogEventListeners@chrome://browser/content/preferences/in-content/subdialogs.js:486:12
[task 2019-06-06T16:32:23.931Z] 16:32:23 INFO - open@chrome://browser/content/preferences/in-content/subdialogs.js:97:10
[task 2019-06-06T16:32:23.931Z] 16:32:23 INFO - asyncopen@chrome://browser/content/preferences/in-content/subdialogs.js:578:25
[task 2019-06-06T16:32:23.932Z] 16:32:23 INFO - openPreferenceDialog@chrome://browser/content/preferences/in-content/containers.js:123:16
[task 2019-06-06T16:32:23.933Z] 16:32:23 INFO - onAddButtonCommand@chrome://browser/content/preferences/in-content/containers.js:108:10
[task 2019-06-06T16:32:23.934Z] 16:32:23 INFO - oncommand@about:preferences#containers:1:17
[task 2019-06-06T16:32:23.935Z] 16:32:23 INFO - openDialog@chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_containers_name_input.js:17:15
[task 2019-06-06T16:32:23.935Z] 16:32:23 INFO - @chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_containers_name_input.js:24:19
[task 2019-06-06T16:32:23.936Z] 16:32:23 INFO - Tester_execTest/<@chrome://mochikit/content/browser-test.js:1115:34
[task 2019-06-06T16:32:23.936Z] 16:32:23 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1143:12
[task 2019-06-06T16:32:23.937Z] 16:32:23 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1004:14
[task 2019-06-06T16:32:23.938Z] 16:32:23 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
[task 2019-06-06T16:32:23.939Z] 16:32:23 INFO -
[task 2019-06-06T16:32:23.939Z] 16:32:23 INFO - Stack trace:
[task 2019-06-06T16:32:23.940Z] 16:32:23 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:1665
[task 2019-06-06T16:32:23.940Z] 16:32:23 INFO - OnErrorEventHandlerNonNullchrome://mochikit/content/tests/SimpleTest/SimpleTest.js:null:1645
[task 2019-06-06T16:32:23.941Z] 16:32:23 INFO - chrome://mochikit/content/browser-test.js:Tester:402
[task 2019-06-06T16:32:23.942Z] 16:32:23 INFO - chrome://mochikit/content/browser-harness.xul:createTester/</<:255
[task 2019-06-06T16:32:23.942Z] 16:32:23 INFO - GECKO(1454) | JavaScript error: chrome://browser/content/preferences/in-content/subdialogs.js, line 223: TypeError: this._frame.contentDocument.documentElement.setInContent is not a function
[task 2019-06-06T16:32:23.944Z] 16:32:23 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_containers_name_input.js | Check the proper URL is loaded -
[task 2019-06-06T16:32:23.945Z] 16:32:23 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_containers_name_input.js | Element should not be null, when checking visibility -
[task 2019-06-06T16:32:23.946Z] 16:32:23 INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-06-06T16:32:23.947Z] 16:32:23 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_containers_name_input.js | Overlay is visible -
[task 2019-06-06T16:32:23.956Z] 16:32:23 INFO - Stack trace:
[task 2019-06-06T16:32:23.958Z] 16:32:23 INFO - chrome://mochikit/content/browser-test.js:test_ok:1313
[task 2019-06-06T16:32:23.959Z] 16:32:23 INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/head.js:is_element_visible:10
[task 2019-06-06T16:32:23.960Z] 16:32:23 INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/head.js:dialogopen:43
[task 2019-06-06T16:32:23.961Z] 16:32:23 INFO - chrome://browser/content/preferences/in-content/subdialogs.js:resizeDialog:313
[task 2019-06-06T16:32:23.962Z] 16:32:23 INFO - chrome://browser/content/preferences/in-content/subdialogs.js:_onLoad:282
[task 2019-06-06T16:32:23.962Z] 16:32:23 INFO - chrome://browser/content/preferences/in-content/subdialogs.js:handleEvent:191
[task 2019-06-06T16:32:23.962Z] 16:32:23 INFO - EventListener.handleEventchrome://browser/content/preferences/in-content/subdialogs.js:_addDialogEventListeners:490
[task 2019-06-06T16:32:23.964Z] 16:32:23 INFO - chrome://browser/content/preferences/in-content/subdialogs.js:open:97
[task 2019-06-06T16:32:23.964Z] 16:32:23 INFO - chrome://browser/content/preferences/in-content/subdialogs.js:open:578
[task 2019-06-06T16:32:23.965Z] 16:32:23 INFO - chrome://browser/content/preferences/in-content/containers.js:openPreferenceDialog:123
[task 2019-06-06T16:32:23.966Z] 16:32:23 INFO - chrome://browser/content/preferences/in-content/containers.js:onAddButtonCommand:108
[task 2019-06-06T16:32:23.966Z] 16:32:23 INFO - about:preferences#containers:oncommand:1
[task 2019-06-06T16:32:23.967Z] 16:32:23 INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_containers_name_input.js:openDialog:17
[task 2019-06-06T16:32:23.968Z] 16:32:23 INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_containers_name_input.js:null:24
[task 2019-06-06T16:32:23.969Z] 16:32:23 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1115
[task 2019-06-06T16:32:23.969Z] 16:32:23 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1143
[task 2019-06-06T16:32:23.969Z] 16:32:23 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1004
[task 2019-06-06T16:32:23.970Z] 16:32:23 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
[task 2019-06-06T16:32:23.972Z] 16:32:23 INFO - found chrome://browser/skin/preferences/preferences.css
[task 2019-06-06T16:32:23.972Z] 16:32:23 INFO - found chrome://global/skin/in-content/common.css
[task 2019-06-06T16:32:23.973Z] 16:32:23 INFO - found chrome://browser/skin/preferences/in-content/preferences.css
[task 2019-06-06T16:32:23.978Z] 16:32:23 INFO - found chrome://browser/skin/preferences/in-content/dialog.css
[task 2019-06-06T16:32:23.978Z] 16:32:23 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_containers_name_input.js | All expectedStyleSheetURLs should have been found -

Comment 11

[alexander :surkov (:asurkov)]

Attachment: Bug 1557252 - add missing style for in-content dialogs, r=bgrins

Comment 12

[alexander :surkov (:asurkov)]

apparently _onContentLoaded [1] triggers before custom element is attached to the element in the test. Let's roll back to the previous version which handles that case as well.

[1] https://searchfox.org/mozilla-central/source/browser/components/preferences/in-content/subdialogs.js#213
[2] browser/components/preferences/in-content/tests/browser_containers_name_input.js

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98973168545e
add missing style for in-content dialogs, r=bgrins

Comment 14

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/98973168545e

Comment 15

[Alexandru Trif, Desktop QA [:atrif]]

Hello!
Reproduced the issue with Firefox 69.0a1 (20190606215319) on Windows 10x64, macOS 10.14, Ubuntu 18.04.
The issue is verified fixed using Firefox 69.0b7 (20190722201635) on Windows 10x64, macOS 10.14, Ubuntu 18.04.