1557259 - [mips] undefined reference to `jsimd_can_rgb_gray'

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, defect)

Description

[Mike Hommey [:glandium]]

[task 2019-06-06T08:41:46.032Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/binutils/bin/ld: ../../media/libjpeg/jccolor.o: in function `jinit_color_converter':
[task 2019-06-06T08:41:46.032Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/media/libjpeg/jccolor.c:595: undefined reference to `jsimd_can_rgb_gray'
[task 2019-06-06T08:41:46.034Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/binutils/bin/ld: /builds/worker/workspace/build/src/media/libjpeg/jccolor.c:595: undefined reference to `jsimd_can_rgb_gray'
[task 2019-06-06T08:41:46.034Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/binutils/bin/ld: /builds/worker/workspace/build/src/media/libjpeg/jccolor.c:596: undefined reference to `jsimd_rgb_gray_convert'
[task 2019-06-06T08:41:46.034Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/binutils/bin/ld: /builds/worker/workspace/build/src/media/libjpeg/jccolor.c:703: undefined reference to `jsimd_c_can_null_convert'
[task 2019-06-06T08:41:46.034Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/binutils/bin/ld: /builds/worker/workspace/build/src/media/libjpeg/jccolor.c:703: undefined reference to `jsimd_c_can_null_convert'
...

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1557259 - Fix CPU_ARCH test for libjpeg on mips.

Comment 2

[Mike Hommey [:glandium]]

Next up:

[task 2019-06-06T09:21:47.611Z] 09:21:47    ERROR -  <instantiation>:13:5: error: invalid token in expression
[task 2019-06-06T09:21:47.611Z] 09:21:47     INFO -  .if $17 != 0
[task 2019-06-06T09:21:47.611Z] 09:21:47     INFO -      ^
[task 2019-06-06T09:21:47.611Z] 09:21:47     INFO -  /builds/worker/workspace/build/src/media/libjpeg/simd/mips/jsimd_dspr2.S:42:5: note: while in macro instantiation
[task 2019-06-06T09:21:47.611Z] 09:21:47     INFO -      SAVE_REGS_ON_STACK 8, $16, $17
[task 2019-06-06T09:21:47.611Z] 09:21:47     INFO -      ^

Yet another thing the clang integrated assembler can't compile.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1557259 - Don't use clang integrated assembler for jsimd_dspr2.S.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 9070193 [details]
Bug 1557259 - Fix CPU_ARCH test for libjpeg on mips.

Beta/Release Uplift Approval Request

• User impact if declined: Build failures on mips and mipsel Linux. Would be nice to have in ESR68 for downstreams.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): NPOTB
• String changes made/needed:

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00dd549cdd25
Fix CPU_ARCH test for libjpeg on mips. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/ecf50d974076
Don't use clang integrated assembler for jsimd_dspr2.S. r=dmajor

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/00dd549cdd25
https://hg.mozilla.org/mozilla-central/rev/ecf50d974076

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/00dd549cdd25
https://hg.mozilla.org/mozilla-central/rev/ecf50d974076

Comment 8

[Julien Cristau [:jcristau]]

What does this do for mips64?

Comment 9

[Mike Hommey [:glandium]]

(In reply to Julien Cristau [:jcristau] from comment #8)

What does this do for mips64?

Nothing. We don't enable the simd code on mips64 per toolkit/moz.configure, and neither does upstream, per https://github.com/libjpeg-turbo/libjpeg-turbo/blob/ec5adb83dd38d31374670129851cccc729b9ce13/simd/CMakeLists.txt#L265-L296

Comment 10

[Mike Hommey [:glandium]]

Mmmm actually, it seems that code is triggered on mips64... according to the libjpeg-turbo build logs for the debian package on mips64el. But the code also has "cast from pointer to integer of different size" warnings, so I'm also not confident that it actually works properly.

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9070193 [details]
Bug 1557259 - Fix CPU_ARCH test for libjpeg on mips.

tier3 build fix, approved for 68.0b10

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cd40c1684a60
https://hg.mozilla.org/releases/mozilla-beta/rev/5baea46a218f