[mips] undefined reference to `jsimd_can_rgb_gray'

RESOLVED FIXED in Firefox 68

Status

defect
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla69

Firefox Tracking Flags

(firefox68 fixed, firefox69 fixed)

Details

Attachments

(2 attachments)

[task 2019-06-06T08:41:46.032Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/binutils/bin/ld: ../../media/libjpeg/jccolor.o: in function `jinit_color_converter':
[task 2019-06-06T08:41:46.032Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/media/libjpeg/jccolor.c:595: undefined reference to `jsimd_can_rgb_gray'
[task 2019-06-06T08:41:46.034Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/binutils/bin/ld: /builds/worker/workspace/build/src/media/libjpeg/jccolor.c:595: undefined reference to `jsimd_can_rgb_gray'
[task 2019-06-06T08:41:46.034Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/binutils/bin/ld: /builds/worker/workspace/build/src/media/libjpeg/jccolor.c:596: undefined reference to `jsimd_rgb_gray_convert'
[task 2019-06-06T08:41:46.034Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/binutils/bin/ld: /builds/worker/workspace/build/src/media/libjpeg/jccolor.c:703: undefined reference to `jsimd_c_can_null_convert'
[task 2019-06-06T08:41:46.034Z] 08:41:46     INFO -  /builds/worker/workspace/build/src/binutils/bin/ld: /builds/worker/workspace/build/src/media/libjpeg/jccolor.c:703: undefined reference to `jsimd_c_can_null_convert'
...

Next up:

[task 2019-06-06T09:21:47.611Z] 09:21:47    ERROR -  <instantiation>:13:5: error: invalid token in expression
[task 2019-06-06T09:21:47.611Z] 09:21:47     INFO -  .if $17 != 0
[task 2019-06-06T09:21:47.611Z] 09:21:47     INFO -      ^
[task 2019-06-06T09:21:47.611Z] 09:21:47     INFO -  /builds/worker/workspace/build/src/media/libjpeg/simd/mips/jsimd_dspr2.S:42:5: note: while in macro instantiation
[task 2019-06-06T09:21:47.611Z] 09:21:47     INFO -      SAVE_REGS_ON_STACK 8, $16, $17
[task 2019-06-06T09:21:47.611Z] 09:21:47     INFO -      ^

Yet another thing the clang integrated assembler can't compile.

Comment on attachment 9070193 [details]
Bug 1557259 - Fix CPU_ARCH test for libjpeg on mips.

Beta/Release Uplift Approval Request

  • User impact if declined: Build failures on mips and mipsel Linux. Would be nice to have in ESR68 for downstreams.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): NPOTB
  • String changes made/needed:
Attachment #9070193 - Flags: approval-mozilla-beta?
Attachment #9070215 - Flags: approval-mozilla-beta?
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/00dd549cdd25
Fix CPU_ARCH test for libjpeg on mips. r=dmajor
https://hg.mozilla.org/integration/autoland/rev/ecf50d974076
Don't use clang integrated assembler for jsimd_dspr2.S. r=dmajor
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

What does this do for mips64?

Flags: needinfo?(mh+mozilla)

(In reply to Julien Cristau [:jcristau] from comment #8)

What does this do for mips64?

Nothing. We don't enable the simd code on mips64 per toolkit/moz.configure, and neither does upstream, per https://github.com/libjpeg-turbo/libjpeg-turbo/blob/ec5adb83dd38d31374670129851cccc729b9ce13/simd/CMakeLists.txt#L265-L296

Flags: needinfo?(mh+mozilla)

Mmmm actually, it seems that code is triggered on mips64... according to the libjpeg-turbo build logs for the debian package on mips64el. But the code also has "cast from pointer to integer of different size" warnings, so I'm also not confident that it actually works properly.

Comment on attachment 9070193 [details]
Bug 1557259 - Fix CPU_ARCH test for libjpeg on mips.

tier3 build fix, approved for 68.0b10

Attachment #9070193 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9070215 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.