Closed Bug 1557307 Opened 2 years ago Closed 13 days ago

Convert the JS tests suites to Python 3. (/js/src/tests/jstests.py )

Categories

(Core :: JavaScript Engine, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: hamzah18051, Unassigned)

References

(Blocks 3 open bugs)

Details

Attachments

(1 obsolete file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:67.0) Gecko/20100101 Firefox/67.0

Type: defect → enhancement
Priority: -- → P2
Blocks: 1465785
Blocks: 1558036
No longer blocks: 1558036
Depends on: 1558036

Depends on D33365

Attachment #9071267 - Attachment description: Bug 1557307 - Convert the JS tests suites to Python 3. (/js/src/tests/jstests.py ) → Bug 1557307 - Convert the JS tests suites to Python 3.(/js/src/tests/jstests.py )
Blocks: 1560408
Blocks: 1560410
Attachment #9071267 - Attachment is obsolete: true

A lot of the changes for this bug were split into multiple other patches and merged there.
I don't exactly what else is remaining here.
(In reply to yozaam from comment #2)

https://docs.python.org/3/library/2to3.html could we just use this?
If you wanna give it a try go ahead, 2to3 is a great tool, along with that you can also take a look at six module as it's a "Python 2 and 3 compatibility library. It provides utility functions for smoothing over the differences between the Python versions with the goal of writing Python code that is compatible on both Python versions."
https://pypi.org/project/six/

Also if you wanna work on the py2 to py3 migration task, here the tree that tracks all the remaining work https://bugzilla.mozilla.org/showdependencytree.cgi?id=1496527&hide_resolved=1

Blocks: testing-py3

IIUC, /js/src/tests/jstests.py is a reftest, and reftests run with python-3: true.
Marking as fixed 👍

Status: UNCONFIRMED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.