Cursor navigation doesn't work in old JsTerm

VERIFIED FIXED in Firefox 68

Status

defect
P2
normal
VERIFIED FIXED
Last month
Last month

People

(Reporter: petersonazv, Assigned: nchevobbe)

Tracking

68 Branch
Firefox 69

Firefox Tracking Flags

(firefox68 verified, firefox69 verified)

Details

Attachments

(2 attachments)

Posted image bug.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1 - Open the devtools (F12) in Firefox Developer Edition 68.0b7 (64-bits)
2 - Go to the Console Tab
3 - Try input any JS Code Eg: "var foo = 'bar'; function foobar(a, b) { return a + b };"
5 - Try to the start of the input;
6 - Try navigate the cursor pressing CTRL + RIGHT (Windows)

Actual results:

The syntax not gonna be hightlighted, and the cursor don't move to the right;

Expected results:

The syntax should be highlighted and the cursor should skip to the next word.

Thanks for the bug report.
Could you check in about:config the value of devtools.webconsole.jsterm.codeMirror ? If it's set to false, turn it to true.
if that doesn't work, maybe you have assistive technologies turned on?

Hi(In reply to Nicolas Chevobbe [:nchevobbe] from comment #1)

Thanks for the bug report.
Could you check in about:config the value of devtools.webconsole.jsterm.codeMirror ? If it's set to false, turn it to true.
if that doesn't work, maybe you have assistive technologies turned on?

Thanks for the fast answer Nicolas.
My devtools.webconsole.jsterm.codeMirror is already set to true.

I checked, and don't have any accessibility/assistive option turned on (in the browser or Windows). That said, the CTRL + RIGHT to navigate between word, works very well in all the others windows (even in the address bar), its just in the console TAB that's not working.

Assignee: nobody → nchevobbe
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P2

Hitting Ctrl+ArrowRight didn't have any effect on windows/linux.
The patch fixes this and add a test to make sure a user can
navigate from word to word using Ctrl (or Alt on OSX) and
Arrow Left/Right keys.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be1ba46ab9fd
Fix JSTerm keyboard navigation in old input. r=Honza.
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Comment on attachment 9070896 [details]
Bug 1557324 - Fix JSTerm keyboard navigation in old input. r=Honza.

Beta/Release Uplift Approval Request

  • User impact if declined: User with assistive technology (or a given pref turned off) can't navigate to next word in the console input with Ctrl + ArrowRight in Windows and Linux
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. On Windows/Linux
  1. Set devtools.webconsole.jsterm.codeMirror to false
  2. Open the console
  3. Enter aa bb cc
  4. Navigate all the way to the start of the input using Ctrl + ArrowLeft (should navigate from word to word)
  5. Navigate all the way to the end of the input using Ctrl + ArrowRight (should navigate from word to word)
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): DevTools bug, simple fix, only affects a fraction of webconsole users, covered by test
  • String changes made/needed:
Attachment #9070896 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Bit confused here, the submitter had devtools.webconsole.jsterm.codeMirror=true per comment 2, that doesn't match the explanation in comment 6.

Flags: needinfo?(nchevobbe)

Yes, but there's another heuristic we are using to check if the user should get the "old" jsterm (if Services.appinfo.accessibilityEnabled is true. I don't know when it's set to true. it seems to come from https://searchfox.org/mozilla-central/rev/c606cdd6d014fee4034da1702d484c0d41b604c9/toolkit/xre/nsAppRunner.cpp#715-723 , but I can't investigate it further).
The lack of syntax highlighting in the screenshot definitely indicates that the user had the old jsterm + the test added in the patch was indeed failing when testing the old jsterm, without the fix.
Hope this clarifies things a bit!

Flags: needinfo?(nchevobbe)

Build ID: 20190611213517
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Build ID: 20190610214846
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Verified as fixed on the latest Nightly build (69.0a1) on Windows 10.

On Windows 7 only the Ctrl + Right command is fixed but the syntax highlighting is still missing.

Tested with the devtools.webconsole.jsterm.codeMirror preference both true and false.

Summary: Syntax hightlight and cursor navigation doesn't work → Cursor navigation doesn't work in old JsTerm

Filed Bug 1558804 for investigating the highlighting issue.

Comment on attachment 9070896 [details]
Bug 1557324 - Fix JSTerm keyboard navigation in old input. r=Honza.

devtools console fix for 68.0b10

Attachment #9070896 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Build ID: 20190613141208
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Verified as fixed on the latest Beta build (v68b10) on Windows 10.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.