Closed
Bug 1557357
Opened 5 years ago
Closed 5 years ago
[wpt-sync] Sync PR 16823 - [LayoutNG] makes margins not collapse if size != intrinsic
Categories
(Testing :: web-platform-tests, defect, P4)
Testing
web-platform-tests
Tracking
(firefox69 fixed)
RESOLVED
FIXED
mozilla69
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync upstream])
Sync web-platform-tests PR 16823 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/16823
Details from upstream follow.
Scott Violet <sky@chromium.org> wrote:
[LayoutNG] makes margins not collapse if size != intrinsic
If a block's size is not equal to the intrinsic size, then margins
should not collapse.Bug: 769039
Change-Id: I13b343cf2421d8d49953a8f780d32772fd5eceef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610303
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Commit-Queue: Scott Violet \<sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#659978}
Assignee | ||
Updated•5 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•5 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Updated•5 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•5 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Updated•5 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Updated•5 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 1•5 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b342a8b867984fb31812ff290b8748d038ad42b
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/2725096b4374 [wpt PR 16823] - [LayoutNG] makes margins not collapse if size != intrinsic, a=testonly
Comment 3•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee | ||
Updated•5 years ago
|
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in
before you can comment on or make changes to this bug.
Description
•