[wpt-sync] Sync PR 16860 - [LayoutNG] Fix the NGExclusionSpaceInternal vectors going out of sync.
Categories
(Core :: CSS Parsing and Computation, defect, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync upstream])
Sync web-platform-tests PR 16860 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/16860
Details from upstream follow.
Ian Kilpatrick <ikilpatrick@chromium.org> wrote:
[LayoutNG] Fix the NGExclusionSpaceInternal vectors going out of sync.
NGExclusion::operator== didn't previous compare shape_data. This turned
out to be a bad optimization. :)Without this we'd end up in a situation where we would have:
- An exclusion vector containing an exclusion with shape data.
- Derived geometry which wasn't tracking shape data.
Bug: 963580
Change-Id: I21746f8fd081ff24658768ee6074122f2e913bd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613560
Commit-Queue: Ian Kilpatrick \<ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger \<cbiesinger@chromium.org>
Reviewed-by: Emil A Eklund \<eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661191}
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/5c2cfca80d0a [wpt PR 16860] - [LayoutNG] Fix the NGExclusionSpaceInternal vectors going out of sync., a=testonly
Comment 2•5 years ago
|
||
bugherder |
Assignee | ||
Updated•5 years ago
|
Description
•