1557424 - Scroll position jumps out-of-range on IRCCloud, take 2

Status: VERIFIED FIXED

(Core :: Panning and Zooming, defect)

Description

[Markus Stange [:mstange]]

There's a part of bug 1551582 that's still happening even after that bug got fixed.

Steps to reproduce:

1. Go to irccloud.mozilla.com and log in with your mozilla LDAP credentials.
2. Go to a channel which has at least one or two pages of unread scrollback.
3. Scroll to the very bottom. There should be a bar at the top that says "[some time span] of unread messages".
4. Press the Esc key.

Expected results:
The bar at the top should disappear and the scrolled contents should remain in the same place.

Actual results:
The bar at the top disappears, but the scrolled contents jump up by the size of the bar. There is blank space at the bottom.

Scrolling resets this odd state back to the normal state; scrolling even very slightly makes the gap disappear instantly.

I'm assuming that this bug was caused by bug 1549625, just like bug 1551582 was, but I haven't verified this.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1557424 - Re-clamp the scroll offset if the composition bounds changes. r=kats

This is similar to bug 1551582, but concerns a main-thread change to the
composition bounds rather than the scrollable rect; either can result in
the scroll range shrinking and therefore a need to re-clamp the scroll offset.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e62e4cad2b1
Re-clamp the scroll offset if the composition bounds changes. r=kats

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6e62e4cad2b1

Comment 4

[Markus Stange [:mstange]]

I can confirm this is fixed in today's Nightly. Thanks!

Comment 5

[Botond Ballo [:botond]]

Comment on attachment 9070656 [details]
Bug 1557424 - Re-clamp the scroll offset if the composition bounds changes. r=kats

Beta/Release Uplift Approval Request

• User impact if declined: On some page structures (such as IRCCloud), an action that resizes the scroll port of a scrollable element (for example, dismissing a notification bar that took up space at the top) can result in an out-of-bounds scroll position followed by a jump on the next scroll.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Similar to bug 1551582, the fix is small and enforces an invariant that should always hold.
• String changes made/needed:

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9070656 [details]
Bug 1557424 - Re-clamp the scroll offset if the composition bounds changes. r=kats

scrolling fix for 68.0b10

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e94a4d5cd811

Comment 8

[Rares Doghi, Desktop QA]

Hi, This issue is verified as fixed in Beta 68.0b10 a well as Nightly 69.0a1 (2019-06-13) .