Closed Bug 1557513 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 17216 - Do not collect GraphicsLayers under svg defs

Categories

(Core :: SVG, defect, P4)

Product:
Core
Component:
SVG
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 17216 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17216
Details from upstream follow.

Philip Rogers <pdr@chromium.org> wrote:

Do not collect GraphicsLayers under svg defs

The \<defs> SVG element creates a hidden subtree that is never directly
rendered or hit test. This subtree has its property tree state rooted at
the root property tree state, and we will crash trying to render content
with this property tree state.

This patch stops collecting GraphicsLayers under hidden subtrees. This
mirrors code added in https://crrev.com/544756 to not paint
GraphicsLayers under hidden subtrees. It is not simple to prevent
GraphicsLayers for PaintLayers in hidden subtrees because we do
not determine the |IsUnderSVGHiddenContainer| bit until PrePaint, which
is after the compositing lifecycle step.

Bug: 969311
Change-Id: I67f81e70dfd046c3fa30f687936e9bbfcf14af7e
Reviewed-on: https://chromium-review.googlesource.com/1648279
WPT-Export-Revision: 3c73238da2775670aa63474ac9b8779e3fa70d08

Component: web-platform-tests → SVG
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1ddebca3f3e9
[wpt PR 17216] - Do not collect GraphicsLayers under svg defs, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1ddebca3f3e9

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.