Add top padding for inline settings page

VERIFIED FIXED in Firefox 69

Status

()

Product:
Toolkit
Component:
Add-ons Manager
Type:
enhancement
Importance:
P3
normal
Status:
VERIFIED FIXED
Opened:
2 months ago
Updated:
Last month

People

(Reporter: c4609174, Assigned: yifei, Mentored)

Tracking

({good-first-bug})

Version:
69 Branch
Target:
mozilla69
Points:
---

Firefox Tracking Flags

(firefox69 verified)

Details

Attachments

(2 attachments)

topPadding.png
24.45 KB, image/png
Details
Bug 1557524 - Add top margin for about:addons inline settings page.
47 bytes, text/x-phabricator-request
Details | Review
Posted image topPadding.png —

Regarding Bug 1545427 and Bug 1532724

In the new HTML about:addons you do have (and also did have AFAIK) some padding at the right and left AFAIK.

However, there is no padding at all from the top. So for consistency, maybe add this?

Otherwise it can look as in the screenshot…

Type: defect → enhancement
Keywords: good-first-bug
Priority: -- → P3

Mentor: mstriemer

If this is your first contribution, please see https://wiki.mozilla.org/WebExtensions/Contribution_Onramp to get started.

Mentor: mstriemer

I would like to try to work on it! :)

Added a top margin for about:addons inline settings page such that
the paddings would be consistent.

Assignee: nobody → yifei
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a1cfd91f793d
Add top margin for about:addons inline settings page. r=mstriemer,rpl
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

https://hg.mozilla.org/mozilla-central/rev/a1cfd91f793d

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox69: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Thanks so much for the patch, Yifei! 🎉 Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition

Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you!

(In reply to Caitlin Neiman [:caitmuenster] from comment #6)

Thanks so much for the patch, Yifei! 🎉 Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition

Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you!

Thank you! I have created a profile: https://mozillians.org/en-US/u/hesyifei/. :D

Awesome! You are vouched. \o/

Welcome onboard! I look forward to seeing you around the project!

Verified as fixed in Win7x64 and MacOS 10.14.1 using FF70.0a1 (20190710215049) and FF69.0b3. The padding is added and looks consistent on all firefox versions that were checked.

Marking bug as verified fixed.

Status: RESOLVED → VERIFIED
status-firefox69: fixed → verified
You need to log in before you can comment on or make changes to this bug.