Add top padding for inline settings page
Categories
(Toolkit :: Add-ons Manager, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | verified |
People
(Reporter: c4609174, Assigned: yifei, Mentored)
Details
(Keywords: good-first-bug)
Attachments
(2 files)
Regarding Bug 1545427 and Bug 1532724
In the new HTML about:addons you do have (and also did have AFAIK) some padding at the right and left AFAIK.
However, there is no padding at all from the top. So for consistency, maybe add this?
Otherwise it can look as in the screenshot…
Updated•2 years ago
|
Comment 1•2 years ago
|
||
Mentor: mstriemer
If this is your first contribution, please see https://wiki.mozilla.org/WebExtensions/Contribution_Onramp to get started.
Added a top margin for about:addons inline settings page such that
the paddings would be consistent.
Updated•2 years ago
|
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a1cfd91f793d Add top margin for about:addons inline settings page. r=mstriemer,rpl
Comment 5•2 years ago
|
||
bugherder |
Comment 6•2 years ago
|
||
Thanks so much for the patch, Yifei! 🎉 Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition
Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you!
(In reply to Caitlin Neiman [:caitmuenster] from comment #6)
Thanks so much for the patch, Yifei! 🎉 Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition
Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you!
Thank you! I have created a profile: https://mozillians.org/en-US/u/hesyifei/. :D
Comment 8•2 years ago
|
||
Awesome! You are vouched. \o/
Welcome onboard! I look forward to seeing you around the project!
Comment 9•2 years ago
|
||
Verified as fixed in Win7x64 and MacOS 10.14.1 using FF70.0a1 (20190710215049) and FF69.0b3. The padding is added and looks consistent on all firefox versions that were checked.
Marking bug as verified fixed.
Description
•