1557524 - Add top padding for inline settings page

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[rugk]

Attachment: topPadding.png

Regarding Bug 1545427 and Bug 1532724

In the new HTML about:addons you do have (and also did have AFAIK) some padding at the right and left AFAIK.

However, there is no padding at all from the top. So for consistency, maybe add this?

Otherwise it can look as in the screenshot…

Comment 1

[Caitlin Neiman [:caitmuenster]]

Mentor: mstriemer

If this is your first contribution, please see https://wiki.mozilla.org/WebExtensions/Contribution_Onramp to get started.

Comment 2

[Yifei He]

I would like to try to work on it! :)

Comment 3

[Yifei He]

Attachment: Bug 1557524 - Add top margin for about:addons inline settings page.

Added a top margin for about:addons inline settings page such that
the paddings would be consistent.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1cfd91f793d
Add top margin for about:addons inline settings page. r=mstriemer,rpl

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a1cfd91f793d

Comment 6

[Caitlin Neiman [:caitmuenster]]

Thanks so much for the patch, Yifei! 🎉 Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition

Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you!

Comment 7

[Yifei He]

(In reply to Caitlin Neiman [:caitmuenster] from comment #6)

Thanks so much for the patch, Yifei! 🎉 Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition

Would you be interested in creating a profile on mozillians.org? I'd be happy to vouch for you!

Thank you! I have created a profile: https://mozillians.org/en-US/u/hesyifei/. :D

Comment 8

[Caitlin Neiman [:caitmuenster]]

Awesome! You are vouched. \o/

Welcome onboard! I look forward to seeing you around the project!

Comment 9

[Madalin Cotetiu]

Verified as fixed in Win7x64 and MacOS 10.14.1 using FF70.0a1 (20190710215049) and FF69.0b3. The padding is added and looks consistent on all firefox versions that were checked.

Marking bug as verified fixed.