Actively reject clang < 4.0 during configure

RESOLVED FIXED in Firefox 69

Status

task
RESOLVED FIXED
Last month
2 days ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla69
Dependency tree / graph

Firefox Tracking Flags

(firefox69 fixed)

Details

Attachments

(1 attachment)

There's a libclang test for bindgen, but we should reject the compiler in the first place. Bug 1394825 didn't do that.

Bug 1394825 bumped the minimum version of clang we use on automation,
for the base toolchain jobs, and there's a libclang test for bindgen,
but we should reject the compiler in the first place.

The check to do that works in both C and C++, contrary to the original
3.6 test that was checking a C++ feature ; the test was later changed
for 3.9, using a check that would have worked in both C and C++, but
the C exception was left around. We remove it now.

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/4778e168c9ac
Actively reject clang < 4.0 during configure. r=mshal
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9070452 [details]
Bug 1557547 - Actively reject clang < 4.0 during configure.

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: This allows the patches from bug 1560044 to work without modification. It's also a useful cleanup, making trying to build with clang < 4.0 fail in a better way than what bug 1394825 did.
  • User impact if declined: See above.
  • Fix Landed on Version: 69
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Configure change only, covered with a very large number of unit tests.
  • String or UUID changes made by this patch: N/A
Attachment #9070452 - Flags: approval-mozilla-esr68?
Blocks: 1560044
You need to log in before you can comment on or make changes to this bug.