1557547 - Actively reject clang < 4.0 during configure

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Mike Hommey [:glandium]]

There's a libclang test for bindgen, but we should reject the compiler in the first place. Bug 1394825 didn't do that.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1557547 - Actively reject clang < 4.0 during configure.

Bug 1394825 bumped the minimum version of clang we use on automation,
for the base toolchain jobs, and there's a libclang test for bindgen,
but we should reject the compiler in the first place.

The check to do that works in both C and C++, contrary to the original
3.6 test that was checking a C++ feature ; the test was later changed
for 3.9, using a check that would have worked in both C and C++, but
the C exception was left around. We remove it now.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4778e168c9ac
Actively reject clang < 4.0 during configure. r=mshal

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/4778e168c9ac

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 9070452 [details]
Bug 1557547 - Actively reject clang < 4.0 during configure.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This allows the patches from bug 1560044 to work without modification. It's also a useful cleanup, making trying to build with clang < 4.0 fail in a better way than what bug 1394825 did.
• User impact if declined: See above.
• Fix Landed on Version: 69
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Configure change only, covered with a very large number of unit tests.
• String or UUID changes made by this patch: N/A

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9070452 [details]
Bug 1557547 - Actively reject clang < 4.0 during configure.

Needed for bug 1560044. Approved for 68.1esr.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/4c1dcf5efb3f