1557624 - correct usage of the global cal import

Status: RESOLVED FIXED

(Calendar :: General, task)

Description

[Magnus Melin [:mkmelin]]

We have a few places where "cal" is used, but not properly imported. Just happens to work (in a limited context) since the define comes in from other included scripts.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1557624_cal_def.patch

These are the ones I could find. It's possible there is more if they are on the second line of the /* global(s) */

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9070500 [details] [diff] [review]
bug1557624_cal_def.patch

Review of attachment 9070500 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good.  I did some searching and found a few more cases: 
- calendar-views.js
- calendar-alarm-widget.js
- gdata-list-tree.js
r+ with those included.  (Also, I see some of these files use commas in the globals list.  Would be good to remove those for consistency.  Up to you if you want to do some of that here while we're at it.)

Comment 3

[Magnus Melin [:mkmelin]]

Seems "global" and commas are the preferred way: https://eslint.org/docs/user-guide/configuring#specifying-globals

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1557624_cal_def.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e5ed77a2a024
correct usage of the global cal import. r=pmorris

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 9070676 [details] [diff] [review]
bug1557624_cal_def.patch

I guess this is needed to make the date/time pickers available to add-ons.

Comment 7

[Jorg K (CEST = GMT+2)]

TB 68 beta / Cal 7.0:
https://hg.mozilla.org/releases/comm-beta/rev/7d11de71c9398aa5a4575b97870264473e711f0f