Improve Preferences accessor
Categories
(Core :: Preferences: Backend, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(1 file)
As discussed in bug 1554559, Part 3; the code has become rather heavy with lots of duplicated code due to how the preferences' getter/setter are defined, like
SetXXX and GetXXX where XXX is one of Bool, Int, Float, CString etc.
We could rewrite some of this through templates. It would make the code shorter.
|
Assignee | |
Comment 1•5 years ago
|
||
We use templates where appropriate instead.
|
|
Assignee | |
Updated•5 years ago
|
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a36380745805 P1. Simplify Preferences' getters code. r=njn
|
||
Comment 3•5 years ago
|
||
Backed out changeset a36380745805 (Bug 1557630) for mochitest failures at test_pluginAudioNotification.html.
Backout: https://hg.mozilla.org/integration/autoland/rev/bcca51931b71fd711d6c405fbffeaba994dd4c4c
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&selectedJob=251144951&revision=a36380745805eba415f2c2098bbb6157c1734816
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=251144951&repo=autoland&lineNumber=6961
|
|
Assignee | |
Comment 4•5 years ago
|
||
The errors are all about stuff like:
JavaScript error: /Users/cltbld/tasks/task_1560250216/build/tests/bin/components/httpd.js, line 3318: NS_ERROR_NOT_AVAILABLE:
looks like an infra error to me.
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/64ba1e5a243b P1. Simplify Preferences' getters code. r=njn
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
|
||
Comment 7•4 months ago
|
||
A key difference between the landings of comment 2 and comment 5 was that the SetIsVoid() special case for GetCString() out param modification on failure was restored.
Description
•