1557717 - Locking network.proxy.no_proxies_on doesn't stick when switching between proxy types.

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Mike Kaply [:mkaply]]

From:

https://bugzilla.mozilla.org/show_bug.cgi?id=1505330#c22

When changing the proxy settings between Manual proxy configuration, Use system proxy settings, Auto-detect proxy settings for this network the 'No proxy for' field becomes active. The weirder behavior is that after inputting any value in, the field becomes read-only again. This wouldn't necessarily be a blocker, because none of the changes to the field are saved, but I consider this confusing enough for the user.

I also discovered this is the case for:

network.proxy.share_proxy_settings
signon.autologin.proxy
network.proxy.autoconfig_url

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1557717 - Locked preferences shouldn't be reenabled.

Comment 2

[Mike Kaply [:mkaply]]

Filed:

https://bugzilla.mozilla.org/show_bug.cgi?id=1557754

for followup fix

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7c35e215255
Locked preferences shouldn't be reenabled. r=Gijs

Comment 4

[Daniel Varga [:dvarga]]

Backed out changeset e7c35e215255 (Bug 1557717) for browser-chrome failure in browser_connection_bug1557717.js.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=250626433&revision=e7c35e21525554d248df624a3eb0f9165f38814e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=250626433&repo=autoland&lineNumber=10994

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=250626433&revision=0e0daa42cb20b50506319a74458983db0af5743c

[task 2019-06-07T16:13:31.138Z] 16:13:31     INFO - GECKO(3332) | ++DOMWINDOW == 3 (0x7ff90322e2e0) [pid = 3403] [serial = 28] [outer = (nil)]
[task 2019-06-07T16:13:31.227Z] 16:13:31     INFO - GECKO(3332) | [Child 3403, Main Thread] WARNING: No active window: file /builds/worker/workspace/build/src/js/xpconnect/src/XPCJSContext.cpp, line 662
[task 2019-06-07T16:13:31.249Z] 16:13:31     INFO - GECKO(3332) | ++DOMWINDOW == 4 (0x7ff903366000) [pid = 3403] [serial = 29] [outer = 0x7ff90322e2e0]
[task 2019-06-07T16:13:31.313Z] 16:13:31     INFO - GECKO(3332) | ++DOMWINDOW == 5 (0x7f926929e000) [pid = 3475] [serial = 6] [outer = 0x7f9265a72020]
[task 2019-06-07T16:13:31.715Z] 16:13:31     INFO - GECKO(3332) | FATAL ERROR: Non-local network connections are disabled and a connection attempt to example.com (93.184.216.34) was made.
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - GECKO(3332) | You should only access hostnames available via the test networking proxy (if running mochitests) or from a test-specific httpd.js server (if running xpcshell tests). Browser services should be disabled or redirected to a local server.
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - GECKO(3332) | Hit MOZ_CRASH(Attempting to connect to non-local address!) at /builds/worker/workspace/build/src/netwerk/base/nsSocketTransport2.cpp:1305
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - GECKO(3332) | #01: mozilla::net::nsSocketTransport::OnSocketEvent(unsigned int, nsresult, nsISupports*) [netwerk/base/nsSocketTransport2.cpp:0]
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - GECKO(3332) | #02: mozilla::net::nsSocketEvent::Run() [netwerk/base/nsSocketTransport2.cpp:92]
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - GECKO(3332) | #03: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1165]
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - GECKO(3332) | #04: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:486]
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - GECKO(3332) | #05: mozilla::net::nsSocketTransportService::Run() [netwerk/base/nsSocketTransportService2.cpp:1015]
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - GECKO(3332) | #06: non-virtual thunk to mozilla::net::nsSocketTransportService::Run() [netwerk/base/nsSocketTransportService2.cpp:0]
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - GECKO(3332) | #07: nsThread::ProcessNextEvent(bool, bool*) [xpcom/threads/nsThread.cpp:1165]
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - GECKO(3332) | #08: NS_ProcessNextEvent(nsIThread*, bool) [xpcom/threads/nsThreadUtils.cpp:486]
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - GECKO(3332) | #09: mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) [ipc/glue/MessagePump.cpp:304]
[task 2019-06-07T16:13:31.716Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.717Z] 16:13:31     INFO - GECKO(3332) | #10: MessageLoop::RunInternal() [ipc/chromium/src/base/message_loop.cc:315]
[task 2019-06-07T16:13:31.717Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.717Z] 16:13:31     INFO - GECKO(3332) | #11: MessageLoop::Run() [ipc/chromium/src/base/message_loop.cc:291]
[task 2019-06-07T16:13:31.717Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.717Z] 16:13:31     INFO - GECKO(3332) | #12: nsThread::ThreadFunc(void*) [xpcom/threads/nsThread.cpp:457]
[task 2019-06-07T16:13:31.717Z] 16:13:31     INFO - 
[task 2019-06-07T16:13:31.839Z] 16:13:31     INFO - GECKO(3332) | #13: _pt_root [nsprpub/pr/src/pthreads/ptthread.c:204]

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c34f0ad043fd
Locked preferences shouldn't be reenabled. r=Gijs

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c34f0ad043fd

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 9070586 [details]
Bug 1557717 - Locked preferences shouldn't be reenabled.

Beta/Release Uplift Approval Request

• User impact if declined: When admins lock certain prefs, they become unlocked.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See:

https://bugzilla.mozilla.org/show_bug.cgi?id=1505330#c22

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just adds an if statement for an additional case for not enabling.

Automated tests were run locally to verify (but they can't be in tree because they change proxies)

• String changes made/needed:

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

Tested the fix on the latest nightly Fx 69.0a1 on macOS 10.13, Ubuntu 18 x64, Windows 10 x64. The "No proxy for" section now remains read-only even when changing between the available radio options.

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9070586 [details]
Bug 1557717 - Locked preferences shouldn't be reenabled.

fix for locked proxy prefs, approved for 68.0b10

Comment 10

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/813ac8b3a652

Comment 11

[Cristian Baica [:cbaica], Release Desktop QA]

Tested the uplift fix on an intermediary Fx68.0b10 buildID: 20190612231006 from treeherder on macOS 10.13, Ubuntu 18.04 and windows 10 x64. The 'No proxies for' field remains read-only when changing between radio values in the UI.