Implement the Intl.DisplayNames proposal
Categories
(Core :: JavaScript: Internationalization API, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: alex.fdm, Assigned: anba, NeedInfo)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-complete)
Attachments
(5 files)
The proposal is now on Stage 2: https://github.com/tc39/proposal-intl-displaynames
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D51855
|
|
Assignee | |
Comment 3•5 years ago
|
||
Adds the standard boilerplate for a new Intl object.
Depends on D52163
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D52164
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D52165
|
|
Assignee | |
Comment 6•5 years ago
|
||
This is the script from bug 1585536, updated to support Intl.DisplayNames.
Depends on D52166
|
|
Assignee | |
Comment 7•5 years ago
|
||
Part 1 increases the unzipped ICU data file size by about 25% and the zipped ICU data file size by about 30%.
| Name | Bytes | Bytes (zipped) |
|---|---|---|
| Baseline | 11.143.312 | 3.173.728 |
| lang_tree + region_tree | 14.409.520 | - |
| Stripped lang_tree + region_tree | 13.753.520 | 4.146.644 |
Where "Stripped lang_tree + region_tree" is everything from lang_tree and region_tree removed which doesn't get used by Intl.DisplayNames. (That's the configuration we would use when actually trying to ship Intl.DisplayNames.)
|
|
||
Comment 8•5 years ago
|
||
The big question on data size, seems to me, is what it does to the Firefox download size overall. Any numbers on that?
|
|
Assignee | |
Comment 9•5 years ago
|
||
Try-build without the changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec5d88f5002b7c6a278cddcd9892c2f515e3030e
Try-build with the changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=98f89077e047fdc2a7e502ecc595b8a8affef046
The try-builds are using opt+shippable for Windows and Linux, and opt for Android (there doesn't seem to be an opt+shippable configuration available for Android). (I'm not 100% sure the "aar" file is the correct file to look at for Android.)
| Platform | Before | After | Increase | Percent | File |
|---|---|---|---|---|---|
| arm32 | 42,440,900 | 43,425,311 | 984,411 | 2.23% | geckoview-default-armeabi-v7a-72.0.xxx.aar |
| arm64 | 47,131,249 | 48,117,817 | 986,568 | 2.09% | geckoview-default-arm64-v8a-72.0.xxx.aar |
| linux64 | 72,997,718 | 73,822,477 | 824,759 | 1.13% | target.tar.bz2 |
| win64 | 74,640,843 | 75,610,428 | 969,585 | 1.30% | target.zip |
| win64 | 51,127,426 | 51,795,302 | 667,876 | 1.31% | target.installer.exe |
|
|
||
Comment 10•5 years ago
|
||
Hm. Bug 1507697 indicates that a percent increase much smaller than any of those numbers, is sufficient to trigger treeherder warning-systems. So at minimum, increases to this degree are something that we are historically concerned about. :-|
I'm not certain where we go with these numbers, right now. Will poke at things/people Monday, I guess.
|
||
Comment 11•5 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:anba, could you have a look please?
For more information, please visit auto_nag documentation.
|
|
||
Comment 12•5 years ago
|
||
Until I poke at people as mentioned in comment 10 (which I seem to have forgotten to do), this is sort of in limbo. Given the time of year and everyone traveling everywhere, it seems like that probably should wait til next year, at this point.
|
|
Assignee | |
Comment 13•4 years ago
|
||
It looks like V8 will soon ship Intl.DisplayNames:
|
||
Comment 14•4 years ago
|
||
This shipped in Chrome M81 (April 7, 2020). We should probably get back to this and workout what the increased binary size means.
|
||
Comment 15•4 years ago
|
||
We have a green light for landing this binary increase size signed off by :bgrinstead and :esmyth.
Ni'ing both to get their final sign-off here and I think we can land.
|
||
Comment 16•4 years ago
|
||
I recommend that we land per the discussion with :gandalf, :dbolter, and :bgrinstead on 2020-02-20. None of the research or metrics I've reviewed since then change my recommendation.
|
||
Comment 17•4 years ago
|
||
:esmyth was the right person to sign off here, so it's fine to land in terms of the binary size increase.
|
||
Updated•4 years ago
|
|
||
Comment 18•4 years ago
|
||
Pushed by abutkovits@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b71ce4f9bca7 Part 1: Add resources for Intl.DisplayNames to ICU data file. r=jwalden https://hg.mozilla.org/integration/autoland/rev/93aa11dd931b Part 2: Add Intl.DisplayNames boilerplate. r=jwalden https://hg.mozilla.org/integration/autoland/rev/a6338066da1f Part 3: Implement Intl.DisplayNames proposal. r=jwalden https://hg.mozilla.org/integration/autoland/rev/8000b189d188 Part 4: Add tests for Intl.DisplayNames. r=jwalden https://hg.mozilla.org/integration/autoland/rev/f816bb1d97cb Part 5: Check in ICU memory usage script and adjust max-memory for Intl.DisplayNames. r=jwalden
|
||
Comment 19•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b71ce4f9bca7
https://hg.mozilla.org/mozilla-central/rev/93aa11dd931b
https://hg.mozilla.org/mozilla-central/rev/a6338066da1f
https://hg.mozilla.org/mozilla-central/rev/8000b189d188
https://hg.mozilla.org/mozilla-central/rev/f816bb1d97cb
|
||
Updated•4 years ago
|
|
|
||
Comment 21•4 years ago
|
||
I thought this is shipping in 78, but I'm getting Intl.DisplayNames is not a constructor in Nightly.
Do we have a bug filed for enabling this?
|
|
Assignee | |
Comment 22•4 years ago
|
||
(In reply to Florian Scholz [:fscholz] (MDN) from comment #21)
Do we have a bug filed for enabling this?
We don't yet have a bug for enabling it. There are still some open issues in the proposal which require fixing before we can consider shipping it. Some of the reported spec bugs have been resolved recently, so we may be able to at least make Intl.DisplayNames available on Nightly.
|
||
Comment 23•4 years ago
|
||
Hi, is there any news on this feature getting enabled? André, could you provide links to the specs bugs if any are still open? Thanks!
|
|
Assignee | |
Comment 24•4 years ago
|
||
I've added patches to enable Intl.DisplayNames just last week in bug 1654116.
|
|
||
Comment 25•4 years ago
|
||
Removing dev-doc-needed from here; we'll track documentation in https://bugzilla.mozilla.org/show_bug.cgi?id=1654116 instead.
Description
•