Closed Bug 1557736 Opened 8 months ago Closed 7 months ago

Fix WPT tests which use Workers with a wrong MIME type

Categories

(Core :: DOM: Workers, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

Attachments

(3 files)

In bug 1523706 I identified a lot of WPT test using mostly text/html for Worker/SharedWorker.

I did some partial automatic rewriting using this script, but there are still more failures that need to be manually fixed.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbf9b9ffb7d11364e30e171a57f15b9376c33b19

Status: NEW → ASSIGNED
Priority: -- → P2

This was done automatically by using the following script: https://gist.github.com/evilpie/50f63f485799c3ac9db3e93142562bca

Do note that this produces some buggy results, which I manually fixed in the next commit.

Depends on D34840

Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c427ac3eb8d1
Mechanical fix for polyglot HTML/JS tests. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/430a929ae5ef
Manually fix some of the tests. r=jgraham
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---

This should fix most the rest of the failing WPT tests when enforcing a JavaScript Mime Type for workers.

There are just some missing, where I am not sure what to do.

Obviously not compatible with the new restriction
web-platform/tests/workers/Worker_script_mimetype.htm

This test uses a .header file. I think I also need to fix 001.html, because the automatic rewriting didn't know about .header
web-platform/tests/workers/semantics/encodings/002.html

These tests all refer to files like 1, null etc. Should we just add .header files for these?
web-platform/tests/workers/constructors/SharedWorker/undefined-arguments.html
web-platform/tests/workers/constructors/SharedWorker/null-arguments.html
web-platform/tests/workers/constructors/SharedWorker/URLMismatchError.html
web-platform/tests/workers/constructors/Worker/ctor-null.html
web-platform/tests/workers/constructors/Worker/ctor-1.html

Oh I think I missed workers/semantics/reporting-errors/001 .. 004.html

Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fb064aea7890
Fix more WPT tests for Workers with a non-JS mime. r=jgraham
Keywords: leave-open
Status: REOPENED → RESOLVED
Closed: 7 months ago7 months ago
Resolution: --- → FIXED
Target Milestone: mozilla69 → mozilla70
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18203 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.