Closed Bug 1557808 Opened 4 years ago Closed 4 years ago

Call BrowserParent::SendSkipBrowsingContextDetach in SendSkipBrowsingContextDetach

Categories

(Core :: DOM: Content Processes, defect, P2)

Product:
Core
Component:
DOM: Content Processes
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Project Flags:
Fission Milestone M3
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

Bug 1557808 - Call BrowserParent::SendSkipBrowsingContextDetach in SendSkipBrowsingContextDetach.
47 bytes, text/x-phabricator-request
Details | Review

nika: "this method does the wrong thing - it grabs the BrowserParent's nsFrameLoader and calls SkipBrowsingContextDetach on it, which is the wrong thing to do, as the nsFrameLoader on a BrowserParent is always the toplevel <xul:browser>'s""

The nsFrameLoader for the BrowserParent is always the toplevel
<xul:browser>'s, but we actaully want to skip the detach for the
browsing context for the current browser child.

Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf5936dc3807
Call BrowserParent::SendSkipBrowsingContextDetach in SendSkipBrowsingContextDetach. r=nika

https://hg.mozilla.org/mozilla-central/rev/bf5936dc3807

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Fission Milestone: --- → M3
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.