Closed Bug 1557812 Opened 6 months ago Closed 6 months ago

Make browser_ext_themes_autocomplete_popup.js use hasAttribute instead of empty string check for non-existent attributes

Categories

(WebExtensions :: General, task)

task
Not set

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

When changing the root node to HTML (Bug 1492582) the return value of a non-existent attribute changes from "" to null.

Type: defect → task

This is a difference between HTML and XUL elements. Updating the test to use hasAttribute instead.

Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d820bbb356aa
Fix test that expects getAttribute to return "" instead of null on documentElement without the attribute r=dao
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Can you please provide some steps so we can manually verify this issue? If no manual testing is needed can you please mark it as "qe-verify- "

Flags: needinfo?(bgrinstead)

qe-verify-, this is a test-only change.

Flags: needinfo?(bgrinstead) → qe-verify-
You need to log in before you can comment on or make changes to this bug.