Closed
Bug 1557942
Opened 6 years ago
Closed 6 years ago
Remove unnecessary usage of `closest()` from searchbar.js
Categories
(Firefox :: Search, task)
Firefox
Search
Tracking
()
RESOLVED
FIXED
Firefox 69
| Tracking | Status | |
|---|---|---|
| firefox69 | --- | fixed |
People
(Reporter: ntim, Assigned: surkov)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Post reviewing bug 1556561, I noticed that I forgot to remove an usage of closest() that's no longer useful after bug 1534404:
https://hg.mozilla.org/integration/autoland/rev/a29be90ae608#l4.125
The anchor variable can go away and be replaced with this, meaning this block can change to:
let { width } = this.getBoundingRect();
popup.setAttribute("width", width > 100 ? width : 100);
// invalidate() depends on the width attribute
popup._invalidate();
popup.openPopup(this, "after_start");
|
Reporter | |
Updated•6 years ago
|
Summary: Remove unnecessary usage of `closest()` in searchbar.js → Remove unnecessary usage of `closest()` from searchbar.js
|
|
Reporter | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Keywords: regression
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → surkov.alexander
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/41b11698353c
Remove unnecessary usage of closest() from searchbar.js r=ntim
|
||
Comment 3•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•