Closed Bug 1557950 Opened 1 year ago Closed 1 year ago

Port bug 1555662: Intermittent toolkit/components/extensions/test/xpcshell/test_ext_redirects.js | application crashed [@ mozilla::dom::DocumentL10n::Init(nsTArray<nsTString<char16_t> >&)]

Categories

(Thunderbird :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 69.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

Bug 1555662 changes how to register the locales.

Maybe the port isn't needed as it still works with only the m-c change. But it's maybe better to follow to do the same as FX to still work also in the future.
This ports https://hg.mozilla.org/integration/autoland/rev/89603d14c1de.

I have no special l10n-registry.manifest added as we package our files together with toolkit into the same omni.ja.

I leave calendar untouched because when I try to follow, it does no more work.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9070790 - Flags: review?(jorgk)
Attachment #9070790 - Flags: feedback?(gandalf)

Oh! Now I see, you may need the package-installer.mn change to package the manifest.

I'm not sure if you have your own FileSource for L10nRegistry. If you do, you may want to follow what I landed in browser/l10n-registry.manifest or keep registering from JS.

Why do M-C have two lines here:
https://hg.mozilla.org/integration/autoland/rev/89603d14c1de#l3.12

+@RESPATH@/components/l10n-registry.manifest
+@RESPATH@/browser/components/l10n-registry.manifest
Flags: needinfo?(gandalf)

(In reply to Jorg K (GMT+2) from comment #3)

Why do M-C have two lines here:
https://hg.mozilla.org/integration/autoland/rev/89603d14c1de#l3.12

+@RESPATH@/components/l10n-registry.manifest
+@RESPATH@/browser/components/l10n-registry.manifest

I'd say this is because FX uses two omni.ja. I wrote already in comment 1 that it works with only the one manifest in toolkit.

OK, thanks.

Flags: needinfo?(gandalf)
Attachment #9070790 - Flags: feedback?(gandalf) → feedback+
Comment on attachment 9070790 [details] [diff] [review]
1557950-register-L10nRegistry.patch

OK, let's go with this. Calendar do their own thing, so let's not touch that:
https://searchfox.org/comm-central/rev/4c59c10067f6f8f772319dbafc369484a78a53e9/calendar/base/src/calStartupService.js#66
Attachment #9070790 - Flags: review?(jorgk) → review+
Keywords: checkin-needed

Nothing to check in here so far, we need to wait for the M-C bug.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/984499e7eacc
Port Bug 1555662: Register L10nRegistry sources using categories. r=jorgk, f=zibi

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 69.0
You need to log in before you can comment on or make changes to this bug.