1557983 - Simplify the complex and broken 'beforeprint'/'afterprint' dispatching code

Status: RESOLVED FIXED

(Core :: Printing: Setup, enhancement, P2)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1557983. Significantly simplify and fix the 'beforeprint'/'afterprint' dispatching code. r=bobowen

This fixes two issue.

First, the code shouldn't be dispatching these events every time it gets a new
Print or PrintPreview call. It only needs to dispatch the events to the
original document that we're going to clone from. When cloning from existing
static clones any changes made by 'beforeprint' will be present in the existing
static clone.

Second, the code tries to delay the 'afterprint' event until after
mozPrintCallback callbacks have been invoked, but those callbacks are invoked
in the cloned document, whereas the events are sent to the original document!
So there is no reason to do this.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1557983. Remove nsPrintJob::HasPrintCallbackCanvas. r=bobowen

After refactoring the 'beforeprint'/'afterprint' code, this method is not used
any more.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f91e5fbb9520
Remove nsPrintJob::HasPrintCallbackCanvas.

Comment 4

[Atila Butkovits]

Backed out as requested.

Backout link: https://hg.mozilla.org/integration/autoland/rev/e3325d8cbd90340adb29a9585926e4397da4c3c1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfbaf61ce16a
Significantly simplify and fix the 'beforeprint'/'afterprint' dispatching code.
https://hg.mozilla.org/integration/autoland/rev/249eede42e9f
Remove nsPrintJob::HasPrintCallbackCanvas.

Comment 6

[Atila Butkovits]

Backed outfor failures at table-background-print.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/b9825b191c1c7179a42ddf932736061bd0430542

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=dytfV8t4R0O1OR_CE4fVjw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=249eede42e9fdd7b58f98b6498fc1a104505fc5f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=309425604&repo=autoland&lineNumber=1342

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25fa445f9702
Significantly simplify and fix the 'beforeprint'/'afterprint' dispatching code.
https://hg.mozilla.org/integration/autoland/rev/907d8172c495
Remove nsPrintJob::HasPrintCallbackCanvas.

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/25fa445f9702
https://hg.mozilla.org/mozilla-central/rev/907d8172c495