1558001 - DOMMatrix converts double into float

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

new DOMMatrix([.9, .8, .7, .6, .5, .4])

Actual results:

DOMMatrix { a: 0.8999999761581421, b: 0.800000011920929, c: 0.699999988079071, d: 0.6000000238418579, e: 0.5, f: 0.4000000059604645, m11: 0.8999999761581421, m12: 0.800000011920929, m13: 0, m14: 0 }

Expected results:

DOMMatrix { a: 0.9, b: 0.8, c: 0.7, d: 0.6, e: 0.5, f: 0.4, m11: 0.9, m12: 0.8, m13: 0, m14: 0 }

The spec defines the constructor argument and attributes as unrestricted doubles and yet the implementation internally uses float.

Comment 1

[Raluca Popovici, Desktop QA]

Hi, I was able to reproduce this issue on my machine with Firefox Release 67, Firefox Beta 68.0b9 and Nightly 69.0a1.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1558001: Use double for DOMMatrix

DOMMatrix now internally uses double instead of float. This only fixes DOMMatrix internals so we still have to work on Servo CSS Parser to pass doubles instead of floats.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm. Did the spec use to say float or something?

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

No prose requires a specific type but the IDL consistently uses unrestricted double.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a488599483ee
Use double for DOMMatrix r=bzbarsky

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a488599483ee

Comment 7

[Julien Cristau [:jcristau] (back April 22)]

I assume this can ride the trains. Please reset status and request uplift if not.