1558023 - captive portal infobar ("Open Network Login Page") no longer goes away automatically and can't be closed

Status: RESOLVED FIXED

(Firefox :: Untriaged, defect)

Description

[giul.mus]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Connect to a network with a captive portal; log in successfully; try to close the bar clicking on the X button.

Actual results:

The X button was highlighted when I put my mouse on it, clicking it changed the highlight color, but otherwise had no effect.

Expected results:

Either the captive portal bar ("You must log in to this network...") closes automatically, or it can be closed clicking on the X button.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I've been seeing this as well for about the past week; I think it was a regression sometime last week or maybe only slightly before. I'm also on 64-bit Linux, running 64-bit nightlies on Ubuntu 18.04 LTS.

It used to be that the infobar disappeared the moment I was logged in; now it no longer does, and the [X] to close it no longer works.

Was Firefox 68 (i.e., beta) the version you were seeing this on? That surprises me a little given that I saw the regression on nightly (Firefox 69) so recently.

Comment 2

[giul.mus]

I've been seeing this in Nightly indeed, and within the same window. I think I filed this under Firefox 69? I did not intend to reference Firefox 68.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

I can try and investigate this sometime soon. needinfo'ing myself to track.

(In reply to David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 from comment #1)

It used to be that the infobar disappeared the moment I was logged in; now it no longer does, and the [X] to close it no longer works.

Do you see any errors in the console when attempting to close the info-bar?

Comment 4

[giul.mus]

(In reply to Nihanth Subramanya [:nhnt11] from comment #3)

Do you see any errors in the console when attempting to close the info-bar?

I think there's nothing relevant. I tried to launch the browser (Nightly 2019-06-11) on a fresh start (so the captive portal was presented), attempted to close the bar before and after logging in, and the only errors of interest in the browser console were:

TypeError: this._textbox is undefined - searchbar.js:164:9
[Exception... "Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIAppStartup.secondsSinceLastOSRestart]"  nsresult: "0x80004001 (NS_ERROR_NOT_IMPLEMENTED)"  location: "JS frame :: resource:///modules/BrowserGlue.jsm :: _collectStartupConditionsTelemetry :: line 1321"  data: no] - BrowserGlue.jsm:1321:39
Error: listener not re-registered (2) - ExtensionCommon.jsm:2129:22
Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. - dnt.js:52
Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. - fingerprinting.js:316
listener not re-registered - ExtensionCommon.jsm:2129
listener not re-registered - ExtensionCommon.jsm:2129
[Exception... "Favicon at "http://<captive portal URL>/favicon.ico" failed to load: Not Found."  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource:///modules/FaviconLoader.jsm :: onStopRequest :: line 199"  data: no] - FaviconLoader.jsm:199:42

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: screenshot of browser console messages

I didn't see any error messages when clicking the [X], but there was some interesting stuff in the browser console...

Comment 6

[Robin Whittleton]

I did manage to close this once after clicking on the bar’s close button ~15 times. I guess it’s opening multiple stacked on top of each other or something?

Comment 7

[giul.mus]

Now that you mention it, that also works for me, though in my case it was more like 7-8 times.

Comment 9

[Dirkjan Ochtman (:djc)]

I'm seeing the same thing (Nightly on macOS). It does indeed appear that it's opening multiple bars -- after clicking the close button many times it went away. You can even spot the animation of it closing (only for the next one to then appear in place).

Comment 10

[(inactive) Nihanth Subramanya [:nhnt11]]

I had some time to investigate this. This seems to be a regression from bug 1556259. The captive-portal-login notification is now being sent multiple times, and the frontend code that receives it is not idempotent, so a new notification is appended for each one.

We should patch the frontend to be idempotent, but also, Valentin, maybe this is something to investigate? Do we want to be sending multiple login notifications like this? If you agree that this is not intentional behavior, I can take a look at CaptiveDetect.jsm and fix that as well in this bug.

Comment 11

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1558023 - Make CaptivePortalWatcher._showNotification idempotent. r=MattN

Comment 12

[(inactive) Nihanth Subramanya [:nhnt11]]

By the way, I also noticed JavaScript error: resource://gre/modules/CaptiveDetect.jsm, line 58: TypeError: xhr.channel is null

Comment 13

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1558023 - [CaptiveDetect.jsm] Check if xhr.channel is null before using it r=mayhemer

Comment 14

[Valentin Gosu [:valentin] (he/him)]

(In reply to Nihanth Subramanya [:nhnt11] from comment #12)

By the way, I also noticed JavaScript error: resource://gre/modules/CaptiveDetect.jsm, line 58: TypeError: xhr.channel is null

Thanks for investigating this. I just submitted a patch to deal with this error.

Do we want to be sending multiple login notifications like this? If you agree that this is not intentional behavior, I can take a look at CaptiveDetect.jsm and fix that as well in this bug.

The patch might™ fix this also, but I haven't checked. Can you open a separate bug for this issue? We should add a test as well.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c23df4c30fc6
[CaptiveDetect.jsm] Check if xhr.channel is null before using it r=mayhemer

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/c23df4c30fc6

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72e37cf73249
Make CaptivePortalWatcher._showNotification idempotent. r=MattN

Comment 18

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/72e37cf73249