Closed Bug 1558030 Opened 2 years ago Closed 2 years ago

Searchbar no longer applies default textbox background

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 69
Tracking Status
firefox69 --- verified

People

(Reporter: yoasif, Assigned: ntim)

References

(Regression)

Details

(Keywords: nightly-community)

Attachments

(3 files)

Attached image bad-search.png

Steps to reproduce:

  1. enable separate search box
  2. use adwaita dark theme

What happens:

bad colors, doesn't look like an input well / too flat

Expected result:

Like prior to Bug 1556561

7:31.11 INFO: Last good revision: 1dbf929c30aea53b8035986ebed5ceb2821f10cb
7:31.11 INFO: First bad revision: a29be90ae6089d1a7adac121c8596df7da2be243
7:31.11 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1dbf929c30aea53b8035986ebed5ceb2821f10cb&tochange=a29be90ae6089d1a7adac121c8596df7da2be243

Attached image good-search.png
Regressed by: 1556561
Has Regression Range: --- → yes
Has STR: --- → yes
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/06b2f9ce5796
Apply a default background to the searchbar. r=dao
Component: XUL Widgets → Theme
Product: Toolkit → Firefox
Summary: Search bar has bad colors/doesn't look like an input well with dark theme → Searchbar no longer applies default textbox background
Assignee: nobody → ntim.bugs
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Flags: qe-verify+

Verified with 69.0b8 on Ubuntu 18.04.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.