1558095 - Updater calls waitpid that does not make sense

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P3)

Description

[Masatoshi Kimura [:emk]]

This waitpid will always fail because waitpid can only wait for children.

Comment 1

[Robert Strong (they/them - no direct email)]

Wow... that's from the original implementation... nice catch!
https://dxr.mozilla.org/mozilla1.8/source/toolkit/mozapps/update/src/updater/updater.cpp#1171

Comment 2

[Masatoshi Kimura [:emk]]

Some random thoughts on the way forward:

1. Just remove the unworking waitpid. On Windows, we have to wait for exiting updater because the operating system will lock running executable files. It does not apply to other platforms.
2. Replace waitpid with polling getppid.
3. Pass a pipe fd instead of a pid and reading the pipe until EOF.
4. Replace waitpid with something specific to platforms (e.g. PR_SET_PDEATHSIG on Linux).

Comment 3

[Robert Strong (they/them - no direct email)]

I think 1 is sufficient since it has been this way forever unless there is some issue someone can think of that this would fix on Linux and Mac.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Bug 1558095 - Remove useless waitpid from updater. r?rstrong

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e74c6c4c5d62
Remove useless waitpid from updater. r=rstrong

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e74c6c4c5d62