1558158 - alternate-server-replay 4.0.4 has the same command line argument as mitmproxy

Status: RESOLVED FIXED

(Testing :: Raptor, defect)

Description

[Florin Strugariu [:Bebe]]

Sometimes we get a crash between mitmproxy replay addon and our updated alternate-server-replay

let's rename server_replay argument to "server_replay_files"

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Bug 1558158 alternate-server-replay 4.0.4 has the same command line argument as mitmproxy

Depends on D34326

Comment 2

[Florin Strugariu [:Bebe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b89bea0542da267ae42d71219c36b5a64ec92549

Comment 3

[Ionuț Goldan [:igoldan]]

(In reply to Florin Strugariu [:Bebe] from comment #0)

Sometimes we get a crash between mitmproxy replay addon and our updated alternate-server-replay

let's rename server_replay argument to "server_replay_files"

Is this on local dev, CI or both? Can you point to some logs or maybe related bugs?

Comment 4

[Florin Strugariu [:Bebe]]

It's not a crash in CI it's a error in MITM. Found it when replaying Netflix files

Addon error: Traceback (most recent call last):
Request https://www.netflix.com/personalization/cl2/freeform/DebugEvent?source=www&action=jsSimplicityPrefetch&statusCode=200&startTime=1560162999627&endTime=1560162999727 has no response data content. Removing from request list
  File "mitmproxy/addons/serverplayback.py", line 174, in configure
  File "mitmproxy/command.py", line 275, in wrapper
Request https://www.netflix.com/customerevents/track/debug has no response data content. Removing from request list
  File "mitmproxy/addons/serverplayback.py", line 79, in load_flows
AttributeError: 'WebSocketFlow' object has no attribute 'response'

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a87127ca83a3
alternate-server-replay 4.0.4 has the same command line argument as mitmproxy r=AlexandruIonescu

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a87127ca83a3