1558169 - Task start date/time is removed upon opening the edit task dialog

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Stefan Sitter [:ssitter]]

STR:
Switch to task tab and create a task with both start date and due date set. Save and close the task. Re-open the task for editing.

Expected:
Start date and due date are enabled and have the previously set values.

Actual:
Start date is disabled / removed.

Comment 1

[Stefan Sitter [:ssitter]]

Regression range:
Works 68.0a1 (2019-05-19)
Fails 68.0a1 (2019-05-20)
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=af02a4451ba2966d9e98f5a881ef21fc8f535a27&tochange=99d648a65b4aeac8108178eb15a07fa951ededc8

Comment 2

[Stefan Sitter [:ssitter]]

This seems to be regressed by Bug 1551081. I reverted the following change:
'- oncommand="checkUntilDate();"
'+ onchange="checkUntilDate();"
and the tasks start date works again. Maybe checkUntilDate() gets triggered during opening the dialog and somehow breaks or modifies start date?

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1558169-item-startdate-1.diff

Your assessment appears to be correct, Stefan.

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9072608 [details] [diff] [review]
1558169-item-startdate-1.diff

Try run says "no". I'll try again tomorrow.

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: 1558169-item-startdate-2.diff

Take two.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/06efd8b78dc6
Fix broken start date/time in task dialog. r=philipp

Comment 7

[Jorg K (CEST = GMT+2)]

TB 68 beta 4 / Cal 7.0:
https://hg.mozilla.org/releases/comm-beta/rev/8a9951252cf61004c8e0f2996547e29e5a1db8b5