Closed Bug 1558188 Opened 1 year ago Closed 1 year ago

Contrast badges become white upon focus via keyboard navigation

Categories

(DevTools :: Accessibility Tools, defect)

defect
Not set

Tracking

(firefox67 disabled, firefox68 verified, firefox69 verified)

VERIFIED FIXED
Firefox 69
Tracking Status
firefox67 --- disabled
firefox68 --- verified
firefox69 --- verified

People

(Reporter: tbabos, Assigned: yzen)

References

Details

Attachments

(3 files)

Attached video Video of the issue

Affected versions
Nightly 69.0a1 (2019-06-09)
Beta 68.0b8 (64-bit)

Affected platforms
Windows 10 x64
Mac OS 10.13
Ubuntu 18.04

Steps to reproduce

  • Go to twitter.com (or any other page)
  • Enable a11y
  • Perform a full page contrast audit
  • Select one of the tree rows with the contrast badge
  • Press TAB

Expected result
The focus should jump to the side panel given that the badges are not interactive anymore.

Actual Result
The badge is focused and becomes fully white, check attached screen recording.

Summary: Contrast badges become white upon via keyboard navigation → Contrast badges become white upon focus via keyboard navigation
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/456cd05b0f87
ensure TreeView's tbody container does not get keyboard focus. r=mtigley
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Comment on attachment 9070961 [details]
Bug 1558188 - ensure TreeView's tbody container does not get keyboard focus. r=mtigley

Beta/Release Uplift Approval Request

  • User impact if declined: Text in accessibility tree badges becomes white and the badges look broken.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): One liner patch just adds tabindex to a table body for the tree (to ensure it does not get focus).
  • String changes made/needed: No
Attachment #9070961 - Flags: approval-mozilla-beta?

Verified - Fixed on latest Nightly 69.0a1 (2019-06-11) (64-bit) on Windows 10 x64, Ubuntu 18.04 and MacOS 10.13.
Badges are not focusable anymore using keyboard only navigation.

Waiting for uplift to beta before closing the bug.

Comment on attachment 9070961 [details]
Bug 1558188 - ensure TreeView's tbody container does not get keyboard focus. r=mtigley

devtools fix, verified in nightly, approved for 68.0b10

Attachment #9070961 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
Regressions: 1559316
Regressions: 1559317

This is also fixed on latest 68.0b10 on Windows 10 x64, MacOS 10.14 and Ubuntu 18.04.
However, it caused 2 new regressions on Nightly and Beta, please check the regressions field.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.