Closed Bug 1558194 Opened 4 months ago Closed 4 months ago

Restyle audit progress bar screen for Dark Devtools theme

Categories

(DevTools :: Accessibility Tools, enhancement)

enhancement
Not set

Tracking

(firefox67 disabled, firefox68 verified, firefox69 verified)

VERIFIED FIXED
Firefox 69
Tracking Status
firefox67 --- disabled
firefox68 --- verified
firefox69 --- verified

People

(Reporter: tbabos, Assigned: yzen)

References

Details

Attachments

(2 files)

Attached video Video of the issue

Affected versions
Nightly 69.0a1 (2019-06-09)
Beta 68.0b8 (64-bit)

Affected platforms
Windows 10 x64
Mac OS 10.13
Ubuntu 18.04

Steps to reproduce

  • Go to twitter.com (or any other page)
  • Enable a11y
  • Set Devtools Dark theme
  • Perform a full page contrast audit

Expected result
The audit progress bar screen should be of a dark color that would match the Dark theme

Actual Result
The default (white) progress bar is displayed. This is slightly disturbing for those who prefer and already set up the Dark devtools theme.

Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/10ef7c0ed049
fix background styling for audit overlay in dark mode. r=mtigley
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Comment on attachment 9070966 [details]
Bug 1558194 - fix background styling for audit overlay in dark mode. r=mtigley

Beta/Release Uplift Approval Request

  • User impact if declined: Progress bar in the dark scheme will look very bright as if for a light scheme.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just changed a background colour to match the dark scheme. 1 line in CSS
  • String changes made/needed: No
Attachment #9070966 - Flags: approval-mozilla-beta?

Verified - Fixed on latest Nightly 69.0a1 (2019-06-11) (64-bit) on Windows 10 x64, Ubuntu 18.04 and MacOS 10.13.
The background color of the progress bar will match the devtools dark theme.
Thanks for the fix!

Waiting for uplift to beta before closing the bug.

Comment on attachment 9070966 [details]
Bug 1558194 - fix background styling for audit overlay in dark mode. r=mtigley

devtools style fix, approved for 68.0b10

Attachment #9070966 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified - Fixed on latest Beta 68.0b10 on Windows 10 x64, Ubuntu 18.04 and MacOS 10.14.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.