1558226 - Event listener tooltip should use the common DevTools arrow.svg expand icon

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Florens Verschelde :fvsch]

The triangle icons used in the event headers are Unicode characters:

.event-header::before {
    content: "▶︎";
}

Two downsides:

• Those characters can render wildly differently between operating systems.
• When changing the character from ▶︎ to ▼ the transition between the two is usually not great, ideally we want to rotation from the center point.

Let's use our theme-twisty icon (devtools/client/themes/images/arrow.svg) instead.

Comment 1

[Florens Verschelde :fvsch]

Attachment: event-header-before-after.png

Hi Victoria, do these small visual tweaks look good to you?
(Left: before; right: after.)

Comment 2

[Florens Verschelde :fvsch]

Attachment: Bug 1558226 - Use theme-twisty in event tooltip headers; r=miker

• Uses theme-twisty for the triangle icon
• Fixed: icon now has the correct orientation in RTL (handled by theme-twisty styles in common.css)
• Fixed: header rows are now always 24px tall excluding the border (before they were all 25px tall, including the first one
• Tweaked: make the event name 12px (our usual "biggish font" size, used in accordion headers and tab labels).

Comment 3

[Florens Verschelde :fvsch]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d26e36eef70881020fce0146c1c6c461bf5fbe7

Comment 4

[Victoria Wang [:victoria]]

Comment on attachment 9071037 [details]
event-header-before-after.png

Wow, these changes are great! Thank you!

Comment 5

[Florens Verschelde :fvsch]

New try push after a rebase, let's see if those oranges are still around.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f53013d95fe982bd8a90b26391858efc75642a5f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/704aa0566495
Use theme-twisty in event tooltip headers; r=miker

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/704aa0566495