Closed Bug 1558263 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17247 - [LayoutNG] Fix negative margin in RTL

Categories

(Core :: CSS Parsing and Computation, defect, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 17247 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17247
Details from upstream follow.

Koji Ishii <kojii@chromium.org> wrote:

[LayoutNG] Fix negative margin in RTL

When there're negative inline margins, |ResolveInlineMargins|
computes incorrect inline-end margin, which affects line
offset in RTL. The inline-end margin computed here is not
used for layout in LTR that the problem was visible only in
RTL.

Bug: 971403
Change-Id: I8cfc6e303649d66b91c95ed1f7a30295c67bcad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647907
Commit-Queue: Emil A Eklund \<eae@chromium.org>
Reviewed-by: Emil A Eklund \<eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#667647}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/c1a145f8e7db [wpt PR 17247] - [LayoutNG] Fix negative margin in RTL, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c1a145f8e7db

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.