Closed Bug 1558272 Opened 2 years ago Closed 2 years ago

Add Windows 10 May 2019 Update to WindowsVersion.h

Categories

(Core :: MFBT, task, P1)

Unspecified
Windows 10
task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

Details

Attachments

(1 file)

Build 18362.

Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Priority: P3 → P1
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/20c4d3173a63
Add Windows 10 May 2019 Update to WindowsVersion.h; r=dmajor
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9071050 [details]
Bug 1558272: Add Windows 10 May 2019 Update to WindowsVersion.h; r=froydnj!

Beta/Release Uplift Approval Request

  • User impact if declined: Possible footgunning down the road if we uplift patches to ESR68 which depends on this detection being in place.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is essentially zero risk. It's just adding detection for the latest release of Windows 10. I'm hoping we can take this now while we're thinking of it so it's not a footgun waiting to burn the trees if we have to uplift a patch to ESR68 which makes use of this sometime during its lifecycle.
  • String changes made/needed:
Attachment #9071050 - Flags: approval-mozilla-beta?

Comment on attachment 9071050 [details]
Bug 1558272: Add Windows 10 May 2019 Update to WindowsVersion.h; r=froydnj!

fair enough. will be in 68.0b10

Attachment #9071050 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.