1558276 - Unify the prefs layers.dump and layers.dump-host-layers

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, P3)

Description

[Botond Ballo [:botond]]

We have two prefs for dumping the compositor-side layer tree: layers.dump and layers.dump-host-layers.

They have subtly different behaviours:

• layers.dump-host-layers is a no-op in a non-MOZ_DUMP_PAINTING build (e.g. a default opt build)
• layers.dump is a no-op for advanced layers, which seems to be the default, at least for local builds

I can see an argument for keeping both (layers.dump-host-layers for symmetry with layers.dump-client-layers, layers.dump because a lot of people know and use that), but there's no reason they should have subtly different behaviour; we should make them exact synonyms. More specifically, they should both work in opt builds, and they should both work for advanced layers.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1558276 - Make layers.dump and layers.dump-host-layers synonyms. r=kats

Now they both work in opt builds, and they both work with advanced layers.

For consistency, layers.dump-client-layers is also modified to work in
opt builds.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f09dc8e08fa1
Make layers.dump and layers.dump-host-layers synonyms. r=kats

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f09dc8e08fa1