1558282 - unsymbolicated libxul.so crash signatures from GeckoView 68 Beta

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Chris Peterson [:cpeterson]]

I see some new unsymbolicated libxul.so crash signatures from GeckoView in Fenix like libxul.so@0xaae770 | libxul.so@0xdfc4bc. The first appearance of these libxul.so signatures was on 2019-06-06.

https://crash-stats.mozilla.com/topcrashers/?product=Fenix&version=68.0b0

Could the new on-demand GeckoView Beta build process have caused a problem uploading GV Beta symbols to Socorro?

Comment 1

[Johan Lorenzo [:jlorenzo]]

Thank you for spotting this bug Chris. I confirm bug 1555959 is the root cause. For instance in [1], geckoview is shipped, but the jobs uploading the symbols (SymN) are missing. The reason is: these jobs aren't triggered if the commit message has DONTBUILD on it. I see how to fix this.

[1] https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=7bc83a8b0212f4aeec916f83ec8c5d5bbd9c8548

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1558282 - 68 train: Bring opt-upload-symbol jobs when shipping geckoview r=Callek

Comment 3

[Johan Lorenzo [:jlorenzo]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a82e30d46f04

Comment 4

[Johan Lorenzo [:jlorenzo]]

I just landed the patch with DONTBUILD in order to reproduce the exact same setup. I then triggered a new geckoview shipment. Please let me know if you still see missing crash signatures.

Comment 6

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1558282 - Bring opt-upload-symbol jobs when shipping geckoview r=Callek

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/552dedefb9cc
Bring opt-upload-symbol jobs when shipping geckoview r=Callek

Comment 8

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 552dedefb9cc (Bug 1558282) for causing linting failure in /builds/worker/checkouts/gecko/taskcluster/taskgraph/target_tasks.py CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=254231117

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=254231117&repo=autoland&lineNumber=273

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2a1dfb66689
Backed out changeset 552dedefb9cc for causing linting failure in /builds/worker/checkouts/gecko/taskcluster/taskgraph/target_tasks.py CLOSED TREE

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc899c83d978
Bring opt-upload-symbol jobs when shipping geckoview r=Callek

Comment 11

[Johan Lorenzo [:jlorenzo]]

Oops! Done.

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/bc899c83d978

Comment 13

[Chris Peterson [:cpeterson]]

68=wontfix. I don't think we need to uplift this fix for GeckoView 68 Beta because the unsymbolicated libxul.so crash rate is pretty low and Fenix will update from GeckoView 68 to 69 Beta soon (probably 2019-07-17 when the next Fenix sprint starts).

Comment 14

[Johan Lorenzo [:jlorenzo]]

Sorry for the confusion, that was fixed in 68 per comment 3.