Closed Bug 1558310 Opened 6 months ago Closed 3 months ago

Remove main thread check in nsStandardURL::nsStandardURL()

Categories

(Core :: Networking, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: mccr8, Assigned: valentin)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

When DEBUG_DUMP_URLS_AT_SHUTDOWN is defined, we track a set of live nsIURIs. Things are added to that set in the nsStandardURL ctor. At some point, a main thread check was added to fix some intermittent crashes, but it looks like the set of URIs is now guarded by a mutex, so that shouldn't be needed any more.

Removing this check will give us information about leaked URIs created off of the main thread.

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task
Assignee: nobody → valentin.gosu
Priority: -- → P3
Whiteboard: [necko-triaged]

Removing this check would allow us to see leaked URIs created off main thread.
This is OK because we already use a mutex to guard the linkedList

Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9017559cb5d4
Remove main thread check in nsStandardURL::nsStandardURL() r=dragana
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.