1558337 - click-and-hold context menus do not appear when touch simulation enabled (TypeError popup is null)

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P2)

Description

[Brad Werth [:bradwerth]]

Appears to be a regression caused by landing of Bug 1505909. Steps to reproduce:

1. Set pref "ui.click_hold_context_menus" to true.
2. Navigate to any site, and open Responsive Design Mode.
3. Turn touch simulation on (UI widget in RDM toolbar should be lit).
4. Click and hold on RDM content.

Expected results:
Context menu should appear.

Actual results:
Browser Console error message: JavaScript error: chrome://browser/content/nsContextMenu.js, line 97: TypeError: popup is null.

Comment 1

[Brad Werth [:bradwerth]]

Note that right-click or modifier-key click still works to make context menu appear.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Thanks for filing. Looking.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1558337 - Add a workaround for RDM for ContextMenuParent.jsm to make context menus work properly. r?NeilDeakin

This workaround hands the top-level browser to nsContextMenu rather than the
mozbrowser in the RDM case. We need to do that since RDM does a lot of work
to make the inner mozbrowser seem like the top-level browser, including
proxying messages from that top-most browser to the underlying mozbrowser.

This workaround makes us consistent with that model, and will have to do until
we can get bug 1559456 fixed.

Depends on D35077

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&author=mconley%40mozilla.com&selectedJob=251929308

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/18dee3d299c1
Add a workaround for RDM for ContextMenuParent.jsm to make context menus work properly. r=NeilDeakin

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/18dee3d299c1

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 18-22]]

Hello,
Reproduced the issue using Firefox 69.0a1 (20190610214846) on Windows 10x64.
The issue is verified fixed with Firefox 69.0b7 (20190722201635) on Windows 10x64, macOS 10.14 and Ubuntu 18.04.