Closed Bug 1558352 Opened 6 months ago Closed 6 months ago

Ensure canvas anonymous content is always created before constructing the document element frame's children.

Categories

(Core :: Layout, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Right now that doesn't happen, so you can run into problems like the one described in bug 1492582 comment 30 for popups.

This is a bit annoying, but it's more consistent with how regular anonymous content works already:

https://searchfox.org/mozilla-central/rev/0da35261b6789eec65476dbdd4913df6e235af6d/layout/base/nsCSSFrameConstructor.cpp#9644

It's still not 100% consistent, since the root element's frame would still end up first in the frame tree, but I think that's both less important and harder to change.

Right now that doesn't happen, so you can run into problems like the one
described in bug 1492582 comment 30 for popups.

This is a bit annoying, but it's more consistent with how regular anonymous
content works already:

https://searchfox.org/mozilla-central/rev/0da35261b6789eec65476dbdd4913df6e235af6d/layout/base/nsCSSFrameConstructor.cpp#9644

It's still not 100% consistent, since the root element's frame would still end
up first in the frame tree, but I think that's both less important and harder to
change. I've left a comment to that effect in the code.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e2af929535f6
Ensure canvas anonymous content is always created before constructing the document element frame's children. r=TYLin
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.