Closed Bug 1558371 Opened 4 months ago Closed 2 months ago

Inactive CSS: Improve tooltip readability in dark mode

Categories

(DevTools :: Inspector: Rules, enhancement, P2)

enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: victoria, Assigned: shellyc23, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(2 files)

Attached image image.png

I noticed the Inactive CSS tooltip looks a bit hard to read in dark mode. I think it would be good to match the Gray10 text color of the meatball menu.

Hi Mike, do you think you could fit this in along with your other Inactive CSS work?

Flags: needinfo?(mratcliffe)

Sure... I will add it to my list.

Flags: needinfo?(mratcliffe)

Thank you!

Thanks for filing Victoria. It would be good to get this in sooner rather than later since we are going to ship this new feature to all users with Firefox 70.
I think this might be a good first bug for someone with css knowledge, so I'm marking it as such. I'll also add Mike as a mentor in case people have questions I'm sure he will be able to help.
Please read our contribution docs first if you haven't yet contributed to firefox devtools: https://docs.firefox-dev.tools/

Mentor: mratcliffe
Keywords: good-first-bug
Priority: -- → P2
Whiteboard: [lang=css]

I would like to take a stab at this.

Please do!

Assignee: nobody → shellyc23

Changed the color in .devtools-tooltip-inactive-css to match the color of the meatball menu

Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10ea0cf78737
Improve tooltip readability in dark mode r=pbro
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
QA Whiteboard: [qa-70b-p2]
You need to log in before you can comment on or make changes to this bug.