1558371 - Inactive CSS: Improve tooltip readability in dark mode

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, enhancement, P2)

Description

[Victoria Wang [:victoria]]

Attachment: image.png

I noticed the Inactive CSS tooltip looks a bit hard to read in dark mode. I think it would be good to match the Gray10 text color of the meatball menu.

Comment 1

[Victoria Wang [:victoria]]

Hi Mike, do you think you could fit this in along with your other Inactive CSS work?

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Sure... I will add it to my list.

Comment 3

[Victoria Wang [:victoria]]

Thank you!

Comment 4

[Patrick Brosset <:pbro>]

Thanks for filing Victoria. It would be good to get this in sooner rather than later since we are going to ship this new feature to all users with Firefox 70.
I think this might be a good first bug for someone with css knowledge, so I'm marking it as such. I'll also add Mike as a mentor in case people have questions I'm sure he will be able to help.
Please read our contribution docs first if you haven't yet contributed to firefox devtools: https://docs.firefox-dev.tools/

Comment 5

[Krishnal Ciccolella]

I would like to take a stab at this.

Comment 6

[Victoria Wang [:victoria]]

Please do!

Comment 7

[Krishnal Ciccolella]

Attachment: Bug 1558371 - Improve tooltip readability in dark mode r=miker

Changed the color in .devtools-tooltip-inactive-css to match the color of the meatball menu

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10ea0cf78737
Improve tooltip readability in dark mode r=pbro

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/10ea0cf78737