Closed Bug 1558439 Opened 3 years ago Closed 3 years ago

Log warning to web console when add-on installation was blocked due to full-screen

Categories

(Toolkit :: Add-ons Manager, enhancement, P3)

Product:
Toolkit
Component:
Add-ons Manager
Platform:
Desktop
Unspecified
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- verified

People

(Reporter: pbz, Assigned: pbz)

References

Details

Attachments

(1 file)

Bug 1558439 - Log warning to web console when add-on installation was blocked due to fullscreen. r=johannh
47 bytes, text/x-phabricator-request
Details | Review

Add-On installation is cancelled / blocked when browser enters / is in full-screen (Bug 1412561). A warning should be logged to the web console when this happens.

Depends on: 1559167
Status: NEW → ASSIGNED
Priority: -- → P3
Attachment #9089384 - Attachment description: Bug 1558439 - Log warning to web console when add-on installation was blocked due to full-screen. r=johannh → Bug 1558439 - Log warning to web console when add-on installation was blocked due to fullscreen. r=johannh
Pushed by pzuhlcke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2720416e190
Log warning to web console when add-on installation was blocked due to fullscreen. r=johannh,mixedpuppy

https://hg.mozilla.org/mozilla-central/rev/b2720416e190

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Verified the fix using the latest Nightly (71.0a1/20190904163258) under Windows 10 Pro 64-bit and macOS High Sierra 10.13.6.

Attempting to install an extension while in full-screen or right before entering full-screen, will properly log a warning in the console, confirming the fix.

Status: RESOLVED → VERIFIED
status-firefox71: fixed → verified

Please add a localization note when introducing strings that are difficult to understand. Who is the intended audience for permissions.fullscreen.promptCanceled and permissions.fullscreen.fullScreenCanceled?

You need to log in before you can comment on or make changes to this bug.