1558445 - Raptor is not raising exception when detecting application timed out

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P1)

Description

[Florin Strugariu [:Bebe]]

We should raise a exception when the application times out while running tests

https://searchfox.org/mozilla-central/source/testing/raptor/raptor/raptor.py#217

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Bug 1558445 Raptor is not raising exception when detecting application timed out

Comment 2

[Robert Wood [:rwood]]

Can we get an update on this issue please, thanks! Setting to P2 as it has been inactive for two weeks.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Bumping back up to P1 as this is causing intermittent failures. It looks like this has been dropped, can we pick this back up? :rwood you are a blocking reviewer, perhaps you could provide your review comments so when Bebe picks this back up we can reduce the review cycles?

Comment 4

[Robert Wood [:rwood]]

Will do thanks for the ping!

Comment 5

[Florin Strugariu [:Bebe]]

Updated please review

Comment 6

[Robert Wood [:rwood]]

Thanks :bebe - LGTM - you're going to have to test this patch really really well before landing please, locally as well as on try (I don't see any try pushes). Thanks!

Comment 7

[Florin Strugariu [:Bebe]]

this patch effects android builds

Tested it locally and waiting on try

Comment 8

[Dave Hunt [:davehunt] [he/him] ⌚BST]

The try push is https://treeherder.mozilla.org/#/jobs?repo=try&revision=e471a7e49447105c66f162278d8e59060b87bb24 and has an excessive number of jobs, which will impact our queues. We can reduce this by only running against pgo builds (not opt), and maybe instead of all jobs for all targets, be more selective for fenix, fennec, and refbrow.

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Dave Hunt [:davehunt] [he/him] ⌚️UTC from comment #8)

The try push is https://treeherder.mozilla.org/#/jobs?repo=try&revision=e471a7e49447105c66f162278d8e59060b87bb24 and has an excessive number of jobs, which will impact our queues. We can reduce this by only running against pgo builds (not opt), and maybe instead of all jobs for all targets, be more selective for fenix, fennec, and refbrow.

I've cancelled these jobs as they accounted for half of the queue (986 jobs). Please push a smaller selection of try jobs.

Comment 10

[Florin Strugariu [:Bebe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d0beb1f9264f18f878a8108ee4213d3ec2b688a

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67e2f19bd3e5
Raptor is not raising exception when detecting application timed out r=perftest-reviewers,rwood

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/67e2f19bd3e5