Closed Bug 1558480 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 17266 - Use `assert_approx_equals` in MediaSource tests

Categories

(Core :: Audio/Video: Playback, defect, P4)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync upstream])

Sync web-platform-tests PR 17266 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17266
Details from upstream follow.

Philip Jägenstedt <philip@foolip.org> wrote:

Use assert_approx_equals in MediaSource tests

The threeDecimalPlaces helper using number.toFixed(3) allowed for
a maximum difference of 0.001 for a pair like 0.0005 / 0.00149999, but
had no lower limit on the difference, a pair like 0.0004999 / 0.0005
would fail.

This may be the cause of a Safari failure !EQ(6.548, 6.549):
https://wpt.fyi/results/media-source/mediasource-endofstream.html?run_id=255090001

Component: web-platform-tests → Audio/Video: Playback
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76fec97619b3
[wpt PR 17266] - Use `assert_approx_equals` in MediaSource tests, a=testonly

https://hg.mozilla.org/mozilla-central/rev/76fec97619b3

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Whiteboard: [wptsync downstream] → [wptsync upstream]
You need to log in before you can comment on or make changes to this bug.