1558504 - Previewing a Set containing an Object seems to be broken

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

STEPS TO REPRODUCE (found by Nicolas Chevobbe)

1. Open console.
2. Type new Set([{a: 1}])
3. Hit enter.

EXPECTED RESULTS: Set [ {…} ] which can be expanded to view the object in it, etc.

ACTUAL RESULTS: Set [ Restricted ] and the expansion does not show the object.

Regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=155a7e2117e575ff6de6caa3dfe5b076cb455ae1&tochange=3f656afb0c08aae2ed9b2ebe4128bac71146c679

My money is on bug 1325195, which rejiggered how enumSetEntries works. The old code used to do:

    const raw = objectActor.obj.unsafeDereference();
    values = [...Cu.waiveXrays(Set.prototype.values.call(raw))];

and the new code does:

  const raw = objectActor.obj.unsafeDereference();
  const iterator =
    objectActor.obj.makeDebuggeeValue(waiveXrays(Set.prototype.values.call(raw)));
  const values = [...DevToolsUtils.makeDebuggeeIterator(iterator)];

which seems quite different, and in particular is not waiving Xrays on the values in the array, afaict, while the old code did.

Comment 1

[Boris Zbarsky [:bzbarsky]]

OK, I confirmed that locally backing out https://hg.mozilla.org/integration/mozilla-inbound/rev/86f6fc53e2fd fixes this for me.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Bug 1558504 - Waive xrays on contents of Set and Map objects when previewing, r=loganfsmyth.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/23f91fec9232
Waive xrays on contents of Set and Map objects when previewing, r=loganfsmyth.

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/23f91fec9232