Closed Bug 1558516 Opened 6 years ago Closed 6 years ago

[mozdevice] Incorrect check for rm effectiveness

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Version:
57 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox69 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla69
Tracking Flags:
Tracking Status
firefox69 --- fixed

People

(Reporter: gbrown, Assigned: gbrown)

Details

Attachments

(1 file)

Bug 1558516 - [mozdevice] Improve check for effectiveness of rm; r=bc
47 bytes, text/x-phabricator-request
Details | Review

The path to rm() (which can be recursive) can be a file or a directory. After executing rm, rm() checks that the path is not a file -- but what if it was a directory?

If path exists in any form after rm, rm() should raise.

Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48fdaccbf5b8 [mozdevice] Improve check for effectiveness of rm; r=bc

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task

https://hg.mozilla.org/mozilla-central/rev/48fdaccbf5b8

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox69: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Type: task → defect
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: