1558524 - Incoming mDNS candidates are ignored

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Dan Minor [:dminor]]

We currently end up ignore incoming mDNS addresses. After they are resolved, we do not send the updated candidate to nICEr here [1] but instead pass in the original candidate with the obfuscated address.

[1] https://searchfox.org/mozilla-central/rev/0da35261b6789eec65476dbdd4913df6e235af6d/media/webrtc/signaling/src/peerconnection/MediaTransportHandler.cpp#1415

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 1558524 - Fix handling of incoming mDNS candidates; r=bwc!

This must have been broken while addressing review comments in Bug 1548841,
the first commit has it right and the last commit in the series breaks it.
Since we don't yet generate mDNS addresses in Firefox, the unit tests would not
catch this problem, and interoperability with other browsers would continue to
work due to peer reflex candidates.

We will have test coverage for this once we land generating our own mDNS
candidates. ICE will fail in the mochitests if we don't support resolving
mDNS addresses properly, which is how I discovered this bug.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/682ce4a4a4de
Fix handling of incoming mDNS candidates; r=bwc

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/682ce4a4a4de