1558540 - [about:addons] The "I want to report this extension to Mozilla" checkbox is still available when removing a Dictionary

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Victor Carciu]

Attachment: Screenshot if issue

Reproduced on Firefox 69.0a1 (2019-06-11) (64-bit)

Steps to reporduce:
1.On Nightly install a dictionary
2.Open about:addons and from Dictionaries section chose to remove it

Expected results:
The "I want to report this extension to Mozilla" checkbox is NOT available when removing a Dictionary

Actual results:
The "I want to report this extension to Mozilla" checkbox is still available when removing a Dictionary

NOTES:
Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1556389
Selecting the checkbox will not perform any actions

Please see attached screenshot

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1558540 - Show report checkbox in uninstall addon dialog only for supported addon types. r?jaws!,mstriemer!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8746baa7c837
Show report checkbox in uninstall addon dialog only for supported addon types. r=jaws,mstriemer

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8746baa7c837

Comment 4

[Victor Carciu]

Verified as fixed in FF 69.0a1 (2019-06-18) using Windows 10x64 and macOS 10.14.5

Please see postfix video

Comment 5

[Victor Carciu]

Attachment: Postfix video

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9071463 [details]
Bug 1558540 - Show report checkbox in uninstall addon dialog only for supported addon types. r?jaws!,mstriemer!

Beta/Release Uplift Approval Request

• User impact if declined: Without this fix a report checkbox would we visible in the "removal dialog" when a user is removing a dictionary or langpack add-on, but we don't currently support abuse report submissions on these add-on types.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same steps used to verify it on Nightly
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pretty small change, which has been backing on Nightly for almost a couple of weeks (and it is also covered by automated tests).
• String changes made/needed:

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9071463 [details]
Bug 1558540 - Show report checkbox in uninstall addon dialog only for supported addon types. r?jaws!,mstriemer!

approved for 68.0b14, thanks

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5e22ca733a30

Comment 9

[Victor Carciu]

Verified as fixed in 68.0b14 (64-bit) on Windows 10x64 and macOS 10.13.6