Closed Bug 1558544 Opened 7 months ago Closed 7 months ago

[RTL] The sliders are overlapping the color preview circle in the new color picker

Categories

(DevTools :: Inspector, defect, P3)

defect

Tracking

(firefox69 verified)

VERIFIED FIXED
Firefox 69
Tracking Status
firefox69 --- verified

People

(Reporter: itiel_yn8, Assigned: mislam)

References

Details

(Keywords: rtl)

Attachments

(2 files)

Attached image Screenshot

See attachment 9066397 [details] vs. the attached screenshot, taken from RTL build.

The order of the items here is okay, just overlapping. Probably because of e.g. margin-right instead of margin-inline-end etc.

Thanks for filing. You are right, the tooltip was modified in bug 1478152, and it looks like the CSS changes done then didn't make use of CSS logical properties: https://hg.mozilla.org/mozilla-central/diff/67b8391890d08c4eabe23de9a77bd0a87cadfef6/devtools/client/shared/widgets/spectrum.css

Flags: needinfo?(mislam)
Priority: -- → P3

Thanks, I will take a look.

Assignee: nobody → mislam
Status: NEW → ASSIGNED
Flags: needinfo?(mislam) → needinfo?(gl)
Flags: needinfo?(gl)

Maliha, re your question in phab-
You can simply set intl.uidirection to 1 (in about:config) and restart to test RTL functionality.

Flags: needinfo?(mislam)

(In reply to Itiel from comment #4)

Maliha, re your question in phab-
You can simply set intl.uidirection to 1 (in about:config) and restart to test RTL functionality.

thank you! It's approved and ready to land :)

Flags: needinfo?(mislam)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mislam, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mislam)
Flags: needinfo?(mislam)
Keywords: checkin-needed

Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/37776bd7e67e
Fix CSS styling for overlapping sliders on color preview, r=gl

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Fixed on latest Nightly.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.