Closed
Bug 1558558
Opened 5 years ago
Closed 5 years ago
New Toggle buttons - color and padding polish
Categories
(DevTools :: Shared Components, defect, P1)
DevTools
Shared Components
Tracking
(firefox69 verified)
VERIFIED
FIXED
Firefox 69
Tracking | Status | |
---|---|---|
firefox69 | --- | verified |
People
(Reporter: victoria, Assigned: nchevobbe)
References
(Depends on 1 open bug)
Details
Attachments
(2 files)
Normal/hover/active colors shown here: https://mozilla.invisionapp.com/share/2XEEY0RYA#/screens/263398480
Looks like the latest update for these buttons may be using the active color, so it's a bit too dark. Also, the padding is slightly less on all sides of the buttons than in the mockup.
Updated•5 years ago
|
Priority: -- → P3
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P3 → P1
Assignee | ||
Comment 1•5 years ago
|
||
here's what it will look like with my patch
Assignee | ||
Comment 2•5 years ago
|
||
Some colors weren't matching the UI spec document,
and the padding was a bit off.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8cc6bacf7bf0 Fix toggle buttons padding and colors. .
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox69:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Comment 5•5 years ago
|
||
Verified with 69.0b3 on Windows 10, macOS 10.13, Ubuntu 16.04.
Changes are in effect for the buttons for both light/dark themes with hover/onClick effects.
Status: RESOLVED → VERIFIED
Updated•2 years ago
|
Component: CSS and Themes → Shared Components
You need to log in
before you can comment on or make changes to this bug.
Description
•