Closed Bug 1558558 Opened 4 months ago Closed 4 months ago

New Toggle buttons - color and padding polish

Categories

(DevTools :: CSS and Themes, defect, P1)

defect

Tracking

(firefox69 verified)

VERIFIED FIXED
Firefox 69
Tracking Status
firefox69 --- verified

People

(Reporter: victoria, Assigned: nchevobbe)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

Normal/hover/active colors shown here: https://mozilla.invisionapp.com/share/2XEEY0RYA#/screens/263398480

Looks like the latest update for these buttons may be using the active color, so it's a bit too dark. Also, the padding is slightly less on all sides of the buttons than in the mockup.

Depends on: 1523842
Priority: -- → P3
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: P3 → P1

here's what it will look like with my patch

Some colors weren't matching the UI spec document,
and the padding was a bit off.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8cc6bacf7bf0
Fix toggle buttons padding and colors. .
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Verified with 69.0b3 on Windows 10, macOS 10.13, Ubuntu 16.04.
Changes are in effect for the buttons for both light/dark themes with hover/onClick effects.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.