Closed Bug 1558574 Opened 4 months ago Closed 4 months ago

clickSelectsAll attribute no longer works on search textboxes

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox67 --- unaffected
firefox67.0.1 --- unaffected
firefox68 --- verified
firefox69 --- verified

People

(Reporter: ntim, Assigned: ntim)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

I forgot to port this from the base textbox binding in bug 1521280.

Keywords: regression
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2807c9fd659d
Re-add support for clickSelectsAll attribute on search-textbox. r=bgrins

Comment on attachment 9071931 [details]
Bug 1558574 - Re-add support for clickSelectsAll attribute on search-textbox. r=bgrins

Beta/Release Uplift Approval Request

  • User impact if declined: Some search inputs will no longer select the text when clicking on them
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
    • Type in the about:preferences searchbox
    • Click on that searchbox
    • see the text select
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial JS patch
  • String changes made/needed: no
Attachment #9071931 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Assignee: nobody → ntim.bugs
QA Whiteboard: [qa-triaged]

Comment on attachment 9071931 [details]
Bug 1558574 - Re-add support for clickSelectsAll attribute on search-textbox. r=bgrins

approved for 68.0b11

Attachment #9071931 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified - Fixed in latest beta 68.0b11 and latest nightly 69.0a1 (2019-06-17) on Windows 10 x64 and Mac OS 10.14.

QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.