Closed
Bug 1558574
Opened 5 years ago
Closed 5 years ago
clickSelectsAll attribute no longer works on search textboxes
Categories
(Toolkit :: UI Widgets, defect)
Toolkit
UI Widgets
Tracking
()
RESOLVED
FIXED
mozilla69
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox67 | --- | unaffected |
| firefox67.0.1 | --- | unaffected |
| firefox68 | --- | verified |
| firefox69 | --- | verified |
People
(Reporter: ntim, Assigned: ntim)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
I forgot to port this from the base textbox binding in bug 1521280.
|
Assignee | |
Updated•5 years ago
|
Keywords: regression
|
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/2807c9fd659d Re-add support for clickSelectsAll attribute on search-textbox. r=bgrins
|
|
Assignee | |
Comment 3•5 years ago
•
|
||
Comment on attachment 9071931 [details]
Bug 1558574 - Re-add support for clickSelectsAll attribute on search-textbox. r=bgrins
Beta/Release Uplift Approval Request
- User impact if declined: Some search inputs will no longer select the text when clicking on them
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce:
- Type in the about:preferences searchbox
- Click on that searchbox
- see the text select
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial JS patch
- String changes made/needed: no
Attachment #9071931 -
Flags: approval-mozilla-beta?
|
|
Assignee | |
Updated•5 years ago
|
Flags: qe-verify+
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
|
||
Updated•5 years ago
|
Assignee: nobody → ntim.bugs
|
||
Updated•5 years ago
|
QA Whiteboard: [qa-triaged]
|
||
Comment 5•5 years ago
|
||
Comment on attachment 9071931 [details]
Bug 1558574 - Re-add support for clickSelectsAll attribute on search-textbox. r=bgrins
approved for 68.0b11
Attachment #9071931 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 6•5 years ago
|
||
| bugherder uplift | ||
|
||
Comment 7•5 years ago
|
||
Verified - Fixed in latest beta 68.0b11 and latest nightly 69.0a1 (2019-06-17) on Windows 10 x64 and Mac OS 10.14.
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
|
|
||
Updated•2 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•