1558630 - Change panel order to reflect popularity

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Comment 1

[:Harald Kirschner :digitarald]

Martin and Victoria for input, if this looks OK or needs further consideration.

Comment 2

[Victoria Wang [:victoria]]

This new order sounds great to me! I remember noticing the Network problem a long time ago but forgot about it, probably due to sortable tabs. Glad you're bringing it up again.

Comment 3

[Florens Verschelde :fvsch]

The order makes sense (and it's where I put Network too :P)

Where would Accessibility fit?

Comment 4

[Martin Balfanz [:mbalfanz]]

Same comment as :fvsch. The order in general makes sense, but I'm missing the accessibility panel.

Comment 5

[:Harald Kirschner :digitarald]

Right now its after Storage, they are on par on usage.

This bug focuses on ordering by usage, so I would not make the call on how to change the order of Storage vs A11Y. We might want to consider other factors and we have another round of re-considerations when we enable the Application panel.

Comment 6

[Florens Verschelde :fvsch]

Attachment: Bug 1558630 - Move Netmonitor tab to 4th place to reflect popularity; r=yulia

Comment 7

[Florens Verschelde :fvsch]

Attachment: Updated panel order in Toolbox toolbar and Settings.png

I made a patch which the Network order change.

On the technical side, tool definitions have an ordinal number and there were a few gaps, plus the Accessibility tool (visible by default) was after the Scratchpad and DOM tools (disabled by default), which can be seen currently in the Settings page. So I've modified the ordinal numbers like this:

Ordinal	Current	Updated
1	Inspector	Inspector
2	Console	Console
3	Debugger	Debugger
4	Style Editor	Network
5	-	Style Editor
6	-	Performance
7	Performance	Memory
8	Memory	Storage
9	Network	Accessibility
10	Storage	Application
11	-	DOM
12	Scratchpad	Scratchpad
13	DOM	-
14	Accessibility	-
15	Application	-

Comment 8

[Florens Verschelde :fvsch]

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78684cf943a937b8fb0a943bf2f00e6a50416bc4&selectedJob=252587238
There are a few oranges, but they seem unrelated?

Comment 9

[Florens Verschelde :fvsch]

Harald, can you review the complete order above ("Updated" column, including hidden-by-default panels)?

Comment 10

[Florens Verschelde :fvsch]

Rebased try push has only one orange, with the orange tests passing locally, so we should be good.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f373b95d16235eb6bb3c493f79d22a8dfc3e3b7

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/421f7c4d60c0
Move Netmonitor tab to 4th place to reflect popularity; r=yulia

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/421f7c4d60c0

Comment 13

[:Harald Kirschner :digitarald]

The new order LGTM, thank you Florens!

Tracking for release notes and updated docs.

Comment 14

[Irene Smith]

This seems like a release notes only thing. Let me know if I'm wrong.

Comment 15

[Florens Verschelde :fvsch]

I'm not sure what changes Harald had in mind.

Network is in 4th position on:

• https://developer.mozilla.org/en-US/docs/Tools
• https://www.mozilla.org/en-US/firefox/developer/

Which looks correct to me.

Not sure we need to call out changing the tab's default position in release notes.

Comment 16

[Irene Smith]

(In reply to Florens Verschelde :fvsch from comment #15)

I'm not sure what changes Harald had in mind.

Network is in 4th position on:

• https://developer.mozilla.org/en-US/docs/Tools
• https://www.mozilla.org/en-US/firefox/developer/

Which looks correct to me.

Not sure we need to call out changing the tab's default position in release notes.

Thanks for the response. I'll mention this to Chris tomorrow at our 1:1 but I agree.

Comment 17

[:Harald Kirschner :digitarald]

LGTM. Toolbar storing isn't consistent in most screenshots across MDN anyways.